Move tests into clientsettingspolicy_test.go

Author: shaun-nx

tests/cel/clientsettingspolicy_test.go

@@ -0,0 +1,176 @@
+package cel
+
+import (
+	"testing"
+
+	gatewayv1alpha2 "sigs.k8s.io/gateway-api/apis/v1alpha2"
+)
+
+func TestClientSettingsPoliciesTargetRefKind(t *testing.T) {
+	allowedKinds := map[string]bool{
+		"Gateway":   true,
+		"HTTPRoute": true,
+		"GRPCRoute": true,
+	}
+
+	testValidTargetRefKind(t, allowedKinds)
+	testInvalidTargetRefKind(t, allowedKinds)
+}
+
+func TestClientSettingsPoliciesTargetRefGroup(t *testing.T) {
+	testValidTargetRefGroup(t)
+	testInvalidTargetRefGroup(t)
+}
+
+func testValidTargetRefKind(t *testing.T, allowedKinds map[string]bool) {
+	t.Helper()
+
+	tests := []struct {
+		name       string
+		wantErrors string
+		targetRef  gatewayv1alpha2.LocalPolicyTargetReference
+	}{
+		{
+			name:       "Validate TargetRef is of an allowed kind",
+			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
+			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+				Kind:  "Gateway",
+				Group: "gateway.networking.k8s.io",
+			},
+		},
+		{
+			name:       "Validate TargetRef is of an allowed kind",
+			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
+			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+				Kind:  "HTTPRoute",
+				Group: "gateway.networking.k8s.io",
+			},
+		},
+		{
+			name:       "Validate TargetRef is of an allowed kind",
+			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
+			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+				Kind:  "GRPCRoute",
+				Group: "gateway.networking.k8s.io",
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if _, ok := allowedKinds[string(tt.targetRef.Kind)]; !ok {
+				gotError := "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'"
+
+				if tt.wantErrors == gotError {
+					t.Errorf("Test %s failed: got error %q, want %q", tt.name, gotError, tt.wantErrors)
+				}
+			}
+		})
+	}
+}
+
+func testInvalidTargetRefKind(t *testing.T, allowedKinds map[string]bool) {
+	t.Helper()
+
+	tests := []struct {
+		name       string
+		wantErrors string
+		targetRef  gatewayv1alpha2.LocalPolicyTargetReference
+	}{
+		{
+			name:       "Validate TargetRef is of an allowed kind",
+			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
+			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+				Kind:  "InvalidKind",
+				Group: "gateway.networking.k8s.io",
+			},
+		},
+		{
+			name:       "Validate TargetRef is of an allowed kind",
+			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
+			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+				Kind:  "TCPRoute",
+				Group: "gateway.networking.k8s.io",
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if _, ok := allowedKinds[string(tt.targetRef.Kind)]; !ok {
+				gotError := "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'"
+
+				if tt.wantErrors != gotError {
+					t.Errorf("Test %s failed: got error %q, want %q", tt.name, gotError, tt.wantErrors)
+				}
+			}
+		})
+	}
+}
+
+func testValidTargetRefGroup(t *testing.T) {
+	t.Helper()
+
+	tests := []struct {
+		name           string
+		wantErrors     string
+		targetRefGroup gatewayv1alpha2.LocalPolicyTargetReference
+	}{
+		{
+			name:       "Validate TargetRef group is gateway.networking.k8s.io",
+			wantErrors: "TargetRef Group must be gateway.networking.k8s.io",
+			targetRefGroup: gatewayv1alpha2.LocalPolicyTargetReference{
+				Group: "gateway.networking.k8s.io",
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if tt.targetRefGroup.Group != "gateway.networking.k8s.io" {
+				gotError := "TargetRef Group must be gateway.networking.k8s.io"
+
+				if tt.wantErrors == gotError {
+					t.Errorf("Test %s failed: got error %q, want %q", tt.name, gotError, tt.wantErrors)
+				}
+			}
+		})
+	}
+}
+
+func testInvalidTargetRefGroup(t *testing.T) {
+	t.Helper()
+
+	tests := []struct {
+		name           string
+		wantErrors     string
+		targetRefGroup gatewayv1alpha2.LocalPolicyTargetReference
+	}{
+		{
+			name:       "Validate TargetRef group is gateway.networking.k8s.io",
+			wantErrors: "TargetRef Group must be gateway.networking.k8s.io",
+			targetRefGroup: gatewayv1alpha2.LocalPolicyTargetReference{
+				Group: "invalid.networking.k8s.io",
+			},
+		},
+		{
+			name:       "Validate TargetRef is of an allowed kind",
+			wantErrors: "TargetRef Group must be gateway.networking.k8s.io",
+			targetRefGroup: gatewayv1alpha2.LocalPolicyTargetReference{
+				Group: "discovery.k8s.io/v1",
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if tt.targetRefGroup.Group != "gateway.networking.k8s.io" {
+				gotError := "TargetRef Group must be gateway.networking.k8s.io"
+
+				if tt.wantErrors != gotError {
+					t.Errorf("Test %s failed: got error %q, want %q", tt.name, gotError, tt.wantErrors)
+				}
+			}
+		})
+	}
+}