use default worker connections constant and remove unessecary tests

Author: sarthyparty

internal/controller/state/dataplane/configuration.go

@@ -22,9 +22,10 @@ import (
 )
 
 const (
-	wildcardHostname     = "~^"
-	alpineSSLRootCAPath  = "/etc/ssl/cert.pem"
-	defaultErrorLogLevel = "info"
+	wildcardHostname         = "~^"
+	alpineSSLRootCAPath      = "/etc/ssl/cert.pem"
+	defaultErrorLogLevel     = "info"
+	defaultWorkerConnections = int32(1024)
 )
 
 // BuildConfiguration builds the Configuration from the Graph.
@@ -1107,8 +1108,6 @@ func buildLogging(gateway *graph.Gateway) Logging {
 }
 
 func buildWorkerConnections(gateway *graph.Gateway) int32 {
-	defaultWorkerConnections := int32(1024)
-
 	if gateway == nil || gateway.EffectiveNginxProxy == nil {
 		return defaultWorkerConnections
 	}

internal/controller/state/dataplane/configuration_test.go

@@ -4907,14 +4907,14 @@ func TestBuildWorkerConnections(t *testing.T) {
 		{
 			msg:                  "NginxProxy is nil",
 			gw:                   &graph.Gateway{},
-			expWorkerConnections: 1024,
+			expWorkerConnections: defaultWorkerConnections,
 		},
 		{
 			msg: "NginxProxy doesn't specify worker connections",
 			gw: &graph.Gateway{
 				EffectiveNginxProxy: &graph.EffectiveNginxProxy{},
 			},
-			expWorkerConnections: 1024,
+			expWorkerConnections: defaultWorkerConnections,
 		},
 		{
 			msg: "NginxProxy specifies worker connections",
@@ -4925,24 +4925,6 @@ func TestBuildWorkerConnections(t *testing.T) {
 			},
 			expWorkerConnections: 2048,
 		},
-		{
-			msg: "NginxProxy specifies minimum worker connections",
-			gw: &graph.Gateway{
-				EffectiveNginxProxy: &graph.EffectiveNginxProxy{
-					WorkerConnections: helpers.GetPointer(int32(1)),
-				},
-			},
-			expWorkerConnections: 1,
-		},
-		{
-			msg: "NginxProxy specifies maximum worker connections",
-			gw: &graph.Gateway{
-				EffectiveNginxProxy: &graph.EffectiveNginxProxy{
-					WorkerConnections: helpers.GetPointer(int32(65535)),
-				},
-			},
-			expWorkerConnections: 65535,
-		},
 	}
 
 	for _, tc := range tests {