Add common finctions for cel tests

Author: shaun-nx

internal/framework/helpers/helpers.go

@@ -9,11 +9,7 @@ import (
 
 	"github.com/google/go-cmp/cmp"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/runtime"
-	controllerruntime "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
-
-	ngfAPIv1alpha1 "github.com/nginx/nginx-gateway-fabric/v2/apis/v1alpha1"
 )
 
 // Diff prints the diff between two structs.
@@ -107,20 +103,3 @@ func RandomPrimeNumber() int64 {
 func UniqueResourceName(name string) string {
 	return fmt.Sprintf("%s-%d", name, RandomPrimeNumber())
 }
-
-// GetKubernetesClient returns a client connected to a real Kubernetes cluster.
-func GetKubernetesClient() (k8sClient client.Client, err error) {
-	// Use controller-runtime to get cluster connection
-	k8sConfig, err := controllerruntime.GetConfig()
-	if err != nil {
-		return nil, err
-	}
-
-	// Set up scheme with NGF types
-	scheme := runtime.NewScheme()
-	if err = ngfAPIv1alpha1.AddToScheme(scheme); err != nil {
-		return nil, err
-	}
-	// Create a new client with the scheme and return it
-	return client.New(k8sConfig, client.Options{Scheme: scheme})
-}

tests/cel/clientsettingspolicy_test.go

@@ -155,7 +155,7 @@ func validateClientSettingsPolicy(t *testing.T, tt struct {
 	t.Helper()
 	g := NewWithT(t)
 
-	k8sClient, err := ngfHelpers.GetKubernetesClient()
+	k8sClient, err := GetKubernetesClient()
 
 	g.Expect(err).ToNot(HaveOccurred())
 

tests/cel/common.go

@@ -0,0 +1,26 @@
+package cel
+
+import (
+	"k8s.io/apimachinery/pkg/runtime"
+	controllerruntime "sigs.k8s.io/controller-runtime"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+
+	ngfAPIv1alpha1 "github.com/nginx/nginx-gateway-fabric/v2/apis/v1alpha1"
+)
+
+// GetKubernetesClient returns a client connected to a real Kubernetes cluster.
+func GetKubernetesClient() (k8sClient client.Client, err error) {
+	// Use controller-runtime to get cluster connection
+	k8sConfig, err := controllerruntime.GetConfig()
+	if err != nil {
+		return nil, err
+	}
+
+	// Set up scheme with NGF types
+	scheme := runtime.NewScheme()
+	if err = ngfAPIv1alpha1.AddToScheme(scheme); err != nil {
+		return nil, err
+	}
+	// Create a new client with the scheme and return it
+	return client.New(k8sConfig, client.Options{Scheme: scheme})
+}