Debug artifact upload and download

Author: shaun-nx

.github/workflows/build.yml

@@ -199,20 +199,20 @@ jobs:
           sarif_file: ${{ steps.scan.outputs.sarif }}
           category: build-${{ inputs.image }}
 
-      - name: Show all image tags for debugging
-        run: echo "${{ steps.meta.outputs.tags }}"
+      # - name: Show all image tags for debugging
+      #   run: echo "${{ steps.meta.outputs.tags }}"
 
-      - name: Pull and save image artifact for linux/amd64
-        if: ${{ (inputs.build-os == 'ubi'|| inputs.image == 'operator') && !inputs.dry_run }}
-        run: |
-          docker pull --platform=linux/amd64 localhost:5000/nginx-gateway-fabric/${{ inputs.image }}:${{ steps.meta.outputs.version }}
-          docker save localhost:5000/nginx-gateway-fabric/${{ inputs.image }}:${{ steps.meta.outputs.version }} -o ${{ inputs.image }}-${{ steps.meta.outputs.version }}.tar
-
-      - name: Upload all image artifacts
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ inputs.image }}-${{ steps.meta.outputs.version }}
-          path: ${{ inputs.image }}-${{ steps.meta.outputs.version }}.tar
+      # - name: Pull and save image artifact for linux/amd64
+      #   if: ${{ (inputs.build-os == 'ubi'|| inputs.image == 'operator') && !inputs.dry_run }}
+      #   run: |
+      #     docker pull --platform=linux/amd64 localhost:5000/nginx-gateway-fabric/${{ inputs.image }}:${{ steps.meta.outputs.version }}
+      #     docker save localhost:5000/nginx-gateway-fabric/${{ inputs.image }}:${{ steps.meta.outputs.version }} -o ${{ inputs.image }}-${{ steps.meta.outputs.version }}.tar
+
+      # - name: Upload all image artifacts
+      #   uses: actions/upload-artifact@v4
+      #   with:
+      #     name: ${{ inputs.image }}-${{ steps.meta.outputs.version }}
+      #     path: ${{ inputs.image }}-${{ steps.meta.outputs.version }}.tar
 
 
       # - name: Run preflight

.github/workflows/ci.yml

@@ -271,6 +271,12 @@ jobs:
           path: ${{ github.workspace }}/dist
           key: nginx-gateway-fabric-${{ github.run_id }}-${{ github.run_number }}
 
+      - name: Upload Artifacts
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: dist-${{ github.run_id }}
+          path: ${{ github.workspace }}/dist
+
   assertion:
     name: Generate and Sign Assertion Documents
     needs: [vars, binary]

.github/workflows/openshift-certification.yml

@@ -44,35 +44,36 @@ jobs:
         chmod +x preflight-linux-amd64
         sudo mv preflight-linux-amd64 /usr/local/bin/preflight
 
-    - name: Download image artifact
-      uses: actions/download-artifact@v4
+    - name: Download Artifacts
+      uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
       with:
-        name: ${{ inputs.image }}-${{ inputs.image_version }}
+        name: dist-${{ github.run_id }}
+        path: ${{ github.workspace }}/dist
 
     - name: List files after artifact download
-      run: ls -l ${{ inputs.image }}-${{ inputs.image_version }}.tar
+      run: ls -l ${{ github.workspace }}/dist
 
-    - name: Load image into Docker
-      run: |
-        docker load -i ${{ inputs.image }}-${{ inputs.image_version }}.tar
+    # - name: Load image into Docker
+    #   run: |
+    #     docker load -i ${{ inputs.image }}-${{ inputs.image_version }}.tar
 
-    - name: Retag image for preflight
-      run: |
-        loaded_tag="localhost:5000/nginx-gateway-fabric/${{ inputs.image }}:${{ inputs.image_version }}"
-        preflight_tag="${{ inputs.image }}:ubi"
-        docker tag "$loaded_tag" "$preflight_tag"
+    # - name: Retag image for preflight
+    #   run: |
+    #     loaded_tag="localhost:5000/nginx-gateway-fabric/${{ inputs.image }}:${{ inputs.image_version }}"
+    #     preflight_tag="${{ inputs.image }}:ubi"
+    #     docker tag "$loaded_tag" "$preflight_tag"
 
-    - name: Run preflight
-      env:
-        PYXIS_API_TOKEN: ${{ secrets.PYXIS_API_TOKEN }}
-      run: preflight check container ${{ inputs.image }}:ubi > preflight-result.json
+    # - name: Run preflight
+    #   env:
+    #     PYXIS_API_TOKEN: ${{ secrets.PYXIS_API_TOKEN }}
+    #   run: preflight check container ${{ inputs.image }}:ubi > preflight-result.json
 
-    - name: Check preflight results
-      run: |
-        failed_count=$(jq '.results.failed | length' preflight-result.json)
-        if [ "$failed_count" -ne 0 ]; then
-        echo "Preflight checks failed: $failed_count failed checks"
-        echo "Results for preflight-result.json:"
-        jq '.results.failed' preflight-result.json
-        exit 1
-        fi
+    # - name: Check preflight results
+    #   run: |
+    #     failed_count=$(jq '.results.failed | length' preflight-result.json)
+    #     if [ "$failed_count" -ne 0 ]; then
+    #     echo "Preflight checks failed: $failed_count failed checks"
+    #     echo "Results for preflight-result.json:"
+    #     jq '.results.failed' preflight-result.json
+    #     exit 1
+    #     fi