Change from map to list

Kate Osborn · Kate Osborn · commit fc6c68c66754 · 2023-12-05T09:15:15.000-07:00
diff --git a/internal/framework/gatewayclass/validate.go b/internal/framework/gatewayclass/validate.go
@@ -69,13 +69,13 @@ func parseVersionString(version string) apiVersion {
 	}
 }
 
-func getBundleVersions(crdMetadata map[types.NamespacedName]*metav1.PartialObjectMetadata) map[string]apiVersion {
-	versions := make(map[string]apiVersion)
+func getBundleVersions(crdMetadata map[types.NamespacedName]*metav1.PartialObjectMetadata) []apiVersion {
+	versions := make([]apiVersion, 0, len(gatewayCRDs))
 
 	for nsname, md := range crdMetadata {
 		if _, ok := gatewayCRDs[nsname.Name]; ok {
 			bundleVersion := md.Annotations[BundleVersionAnnotation]
-			versions[bundleVersion] = parseVersionString(bundleVersion)
+			versions = append(versions, parseVersionString(bundleVersion))
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -69,13 +69,13 @@ func parseVersionString(version string) apiVersion {`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`
`72`		`-func getBundleVersions(crdMetadata map[types.NamespacedName]*metav1.PartialObjectMetadata) map[string]apiVersion {`
`73`		`- versions := make(map[string]apiVersion)`
	`72`	`+func getBundleVersions(crdMetadata map[types.NamespacedName]*metav1.PartialObjectMetadata) []apiVersion {`
	`73`	`+ versions := make([]apiVersion, 0, len(gatewayCRDs))`
`74`	`74`
`75`	`75`	`for nsname, md := range crdMetadata {`
`76`	`76`	`if _, ok := gatewayCRDs[nsname.Name]; ok {`
`77`	`77`	`bundleVersion := md.Annotations[BundleVersionAnnotation]`
`78`		`- versions[bundleVersion] = parseVersionString(bundleVersion)`
	`78`	`+ versions = append(versions, parseVersionString(bundleVersion))`
`79`	`79`	`}`
`80`	`80`	`}`
`81`	`81`