Skip to content

Commit ff09c59

Browse files
committed
Conformance: update input flags
Problem: The upstream conformance library updated their input validation for some flags, causing our nightly tests to fail. Solution: Update the way we initialize these flags so that they pass.
1 parent f8ee6d1 commit ff09c59

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

tests/conformance/conformance_test.go

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323

2424
. "github.com/onsi/gomega"
2525
"sigs.k8s.io/gateway-api/conformance"
26-
conf_v1 "sigs.k8s.io/gateway-api/conformance/apis/v1"
2726
"sigs.k8s.io/gateway-api/conformance/tests"
2827
"sigs.k8s.io/gateway-api/conformance/utils/flags"
2928
"sigs.k8s.io/gateway-api/conformance/utils/suite"
@@ -41,16 +40,12 @@ func TestConformance(t *testing.T) {
4140
*flags.ConformanceProfiles, *flags.SkipTests,
4241
)
4342

43+
*flags.ImplementationOrganization = "nginx"
44+
*flags.ImplementationProject = "nginx-gateway-fabric"
45+
*flags.ImplementationURL = "https://github.com/nginx/nginx-gateway-fabric"
46+
*flags.ImplementationContact = "https://github.com/nginx/nginx-gateway-fabric/discussions/new/choose"
47+
4448
opts := conformance.DefaultOptions(t)
45-
opts.Implementation = conf_v1.Implementation{
46-
Organization: "nginx",
47-
Project: "nginx-gateway-fabric",
48-
URL: "https://github.com/nginx/nginx-gateway-fabric",
49-
Version: *flags.ImplementationVersion,
50-
Contact: []string{
51-
"https://github.com/nginx/nginx-gateway-fabric/discussions/new/choose",
52-
},
53-
}
5449

5550
testSuite, err := suite.NewConformanceTestSuite(opts)
5651
g.Expect(err).To(Not(HaveOccurred()))

0 commit comments

Comments
 (0)