Fix whitespace in improved test workflow

Author: ciarams87

.github/workflows/test-secure-build.yml

@@ -19,9 +19,12 @@ permissions:
 
 jobs:
   test-production-conditions:
-    name: Test Production Logic (GitHub-hosted fallback)
-    # Test the logic but fallback to GitHub-hosted if self-hosted unavailable
+    name: Test Production Logic & Artifactory
+    # Test production artifactory and logic using GitHub-hosted runner
     runs-on: ubuntu-24.04
+    env:
+      # Override to test production artifactory
+      GOPROXY: ${{ github.repository_owner == 'nginx' && format('https://{0}:{1}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-local-approved-dependency', secrets.ARTIFACTORY_USER, secrets.ARTIFACTORY_TOKEN) || 'direct' }}
     steps:
       - name: Checkout Repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -54,43 +57,32 @@ jobs:
 
       - name: Test Production Artifactory Access
         run: |
-          echo "🔐 Testing Artifactory Access:"
-          echo "Current GOPROXY (should be dev for this branch): $GOPROXY"
+          echo "🔐 Testing Production Artifactory Access:"
+          echo "Current GOPROXY (forced to production): $GOPROXY"
 
-          # Test what production GOPROXY would be
-          export TEST_PROD_GOPROXY="${{ github.repository_owner == 'nginx' && format('https://{0}:{1}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-local-approved-dependency', secrets.ARTIFACTORY_USER, secrets.ARTIFACTORY_TOKEN) || 'direct' }}"
-          echo "Production GOPROXY would be: $TEST_PROD_GOPROXY"
-
-          # Test what development GOPROXY is
-          export TEST_DEV_GOPROXY="${{ github.repository_owner == 'nginx' && format('https://{0}:{1}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-dev', secrets.ARTIFACTORY_USER, secrets.ARTIFACTORY_TOKEN) || 'direct' }}"
-          echo "Development GOPROXY (current): $TEST_DEV_GOPROXY"
-
-          # Verify current behavior
-          if [[ "$GOPROXY" == *"f5-nginx-go-dev"* ]]; then
-          echo "✅ SUCCESS: Using development artifactory as expected for feature branch"
+          # Verify we're using production artifactory
+          if [[ "$GOPROXY" == *"f5-nginx-go-local-approved-dependency"* ]]; then
+          echo "✅ SUCCESS: Using production artifactory for testing"
           elif [[ "$GOPROXY" == "direct" ]]; then
           echo "ℹ️  INFO: Using direct proxy (expected for forks)"
           else
-          echo "ℹ️  INFO: Unexpected GOPROXY configuration"
+          echo "❌ ERROR: Expected production artifactory but got: $GOPROXY"
           fi
 
-          # Test that production URL is properly formatted
-          if [[ "$TEST_PROD_GOPROXY" == *"f5-nginx-go-local-approved-dependency"* ]]; then
-          echo "✅ SUCCESS: Production artifactory URL is correctly formatted"
-          else
-          echo "❌ ERROR: Production artifactory URL formatting issue"
-          fi
+          # Show what development would be for comparison
+          export TEST_DEV_GOPROXY="${{ github.repository_owner == 'nginx' && format('https://{0}:{1}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-dev', secrets.ARTIFACTORY_USER, secrets.ARTIFACTORY_TOKEN) || 'direct' }}"
+          echo "Development GOPROXY would be: $TEST_DEV_GOPROXY"
 
       - name: Setup Golang Environment
         uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
         with:
           go-version: stable
           cache-dependency-path: go.sum
-          # Use current GOPROXY (development for this branch)
+          # Use current GOPROXY
 
       - name: Test Go Module Resolution
         run: |
-          echo "🧪 Testing Go Module Resolution:"
+          echo "🧪 Testing Go Module Resolution with Production Artifactory:"
 
           # Test basic Go functionality
           go version
@@ -101,11 +93,11 @@ jobs:
           go list -m all > /tmp/modules.txt 2>/dev/null || true
           head -10 /tmp/modules.txt 2>/dev/null || echo "No modules found"
 
-          # Test downloading a common dependency
-          echo "Testing module download (read-only):"
+          # Test downloading a common dependency from production artifactory
+          echo "Testing module download from production artifactory:"
           go mod download github.com/stretchr/testify 2>/dev/null || echo "Download attempted"
 
-          echo "✅ SUCCESS: Go module resolution working with development artifactory"
+          echo "✅ SUCCESS: Go module resolution working with production artifactory"
 
       - name: Test Environment Variables
         run: |
@@ -127,7 +119,7 @@ jobs:
           echo ""
           echo "Expected for this test:"
           echo "- Runner logic: ✅ (tested and validated)"
-          echo "- Development artifactory: ✅ (not main branch)"
+          echo "- Production artifactory: ✅ (forced for testing)"
           echo "- Repository owner check: ✅ (nginx repo)"
           echo "- Self-hosted availability: ⚠️  (not tested due to runner availability)"
 
@@ -188,7 +180,7 @@ jobs:
           echo ""
           echo "This test validates:"
           echo "✅ Runner selection logic (conditions tested)"
-          echo "✅ Development artifactory configuration (expected for feature branches)"
+          echo "✅ Production vs Development artifactory access"
           echo "✅ Fork safety (repository_owner checks)"
           echo "✅ Condition logic correctness"
           echo ""