Skip to content

Conversation

lucacome
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added the tests Pull requests that update tests label Sep 24, 2024

This comment was marked as outdated.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (4aa68d7) to head (b722ce4).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
+ Coverage   88.62%   95.19%   +6.56%     
==========================================
  Files         105        1     -104     
  Lines        8109      229    -7880     
  Branches       50       50              
==========================================
- Hits         7187      218    -6969     
+ Misses        865       11     -854     
+ Partials       57        0      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 27, 2024

Test Results

42 tests   42 ✅  0s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit b722ce4.

♻️ This comment has been updated with latest results.

@nginx-bot
Copy link
Contributor

Test Summary - Run #8189

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
1490 1489 1 0 0 0 0 00:00:20

Some tests failed!

Name Status Failure Message
TestGetBuildInfo failed ❌ commands_test.go:576: Expected : unknown not to equal : unknown --- FAIL: TestGetBuildInfo (0.00s)

Github Actions Test Reporter CTRF

@nginx-bot
Copy link
Contributor

Test Summary - Run #8190

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
1490 1489 1 0 0 0 0 00:00:19

Some tests failed!

Name Status Failure Message
TestGetBuildInfo failed ❌ --- FAIL: TestGetBuildInfo (0.00s)

Github Actions Test Reporter CTRF

@lucacome lucacome closed this Oct 7, 2024
@lucacome lucacome deleted the tests/report branch October 7, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants