Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 5, 2025

Update with NFR test results for NGF version edge ["oss","plus"]

  • Auto-generated by the NFR tests workflow run 17568230708
  • Tests ran using Docker image tag edge
  • scale test(s) ran

Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seeing some increases in latency and memory usage. Also quite a few error logs for conflicting status updates and no live upstreams.

@bjee19
Copy link
Contributor

bjee19 commented Sep 5, 2025

Though something to note is the edge results are from March 2025, about 6 months ago.

Also I just realized, annoyingly, files that didn't get generated, don't get removed from the edge results. So for example in the scale/edge/TestScale_UpstreamServers/ngf-plus.log there are logs from october 2024, since past then that were no ngf error logs so that file never got generated. But this bot doesn't remove the file. @sjberman think this could be a possible improvement to the nfr workflow?

@salonichf5 salonichf5 marked this pull request as ready for review September 5, 2025 17:11
@salonichf5 salonichf5 requested a review from a team as a code owner September 5, 2025 17:11
@salonichf5
Copy link
Contributor

Though something to note is the edge results are from March 2025, about 6 months ago.

Also I just realized, annoyingly, files that didn't get generated, don't get removed from the edge results. So for example in the scale/edge/TestScale_UpstreamServers/ngf-plus.log there are logs from october 2024, since past then that were no ngf error logs so that file never got generated. But this bot doesn't remove the file. @sjberman think this could be a possible improvement to the nfr workflow?

Yes I saw that too, if nothing gets generated they don't get overwritten.

I was just discussing things @sjberman offline, he recommended we take note of CPU usage and memory for NGINX pods as well. We only do it for NGF now. So I was going to open a story for that, i'll add this in the acceptance criteria too since we need to make sure we get updated results.

@sjberman
Copy link
Collaborator

sjberman commented Sep 5, 2025

@bjee19 Yeah we should probably have some automation to clean those up. For now, we should just manually remove what isn't needed.

@github-actions github-actions bot force-pushed the tests/nfr-tests-edge branch from 24998a9 to 23fcaca Compare September 8, 2025 18:11
@github-actions github-actions bot requested a review from a team as a code owner September 8, 2025 18:11
@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from 35e5317 to 0f8145f Compare September 9, 2025 00:43
@github-actions github-actions bot force-pushed the tests/nfr-tests-edge branch 2 times, most recently from 53bd733 to 40dab28 Compare September 9, 2025 15:36
@github-actions github-actions bot force-pushed the tests/nfr-tests-edge branch from 40dab28 to f334875 Compare September 9, 2025 17:23
@salonichf5 salonichf5 force-pushed the tests/nfr-investigation branch from c8be7d6 to 32cd201 Compare September 9, 2025 17:27
@salonichf5 salonichf5 closed this Sep 9, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants