OpenShift Support: Product Telemetry #4038
Conversation
github-actions
bot
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4038 +/- ##
==========================================
+ Coverage 86.83% 95.19% +8.35%
==========================================
Files 128 1 -127
Lines 16607 229 -16378
Branches 62 62
==========================================
- Hits 14421 218 -14203
+ Misses 2004 11 -1993
+ Partials 182 0 -182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if buildOS == "" { | ||
| buildOS = "alpine" | ||
| } |
There was a problem hiding this comment.
I don't think we need this since we have the check in commands.go. So like how we don't add an additional check for ImageSource I think we can follow suite.
There was a problem hiding this comment.
We'll need to add the field to the "Normal Case"
|
|
||
| var _ = Describe("Collector", Ordered, func() { | ||
|
|
||
| Describe("BuildOS field", func() { |
There was a problem hiding this comment.
I don't really think a new Describe block is needed once you add the field in the normal case. Similar to how we don't have a separate Describe block for ImageSource, but if you insist on keeping it, we should move to down towards the other Describe blocks (probably end of file). Currently this is in a weird place.
Proposed changes
This change adds the
BuildOSfield to our product telemetry.Closes #4037
Blocked by #4008
Should not be merged until feat/inference-extension is merged
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.