Skip to content

Conversation

sjberman
Copy link
Collaborator

Problem: Many of our test changes also include markdown file changes, and the docs label is prioritized in our release notes over tests. This means that the docs sections of the notes often contained many tests changes.

Solution: Prioritize the test label first over docs to hopefully better organize release notes.

Problem: Many of our test changes also include markdown file changes, and the docs label is prioritized in our release notes over tests. This means that the docs sections of the notes often contained many tests changes.

Solution: Prioritize the test label first over docs to hopefully better organize release notes.
@sjberman sjberman requested a review from a team as a code owner September 24, 2024 16:39
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 24, 2024
@sjberman
Copy link
Collaborator Author

@lucacome I'm assuming this is how the labeler works, but do you know if I'm wrong about this?

@lucacome
Copy link
Contributor

That's how it works AFAIK

@sjberman sjberman enabled auto-merge (squash) September 25, 2024 19:03
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (574b6e5) to head (af16bb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2599   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files         100      100           
  Lines        7642     7642           
  Branches       50       50           
=======================================
  Hits         6817     6817           
  Misses        768      768           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman merged commit 3af2393 into nginx:main Sep 25, 2024
42 checks passed
@sjberman sjberman deleted the chore/label-priority branch September 25, 2024 19:31
salonichf5 pushed a commit that referenced this pull request Oct 8, 2024
Problem: Many of our test changes also include markdown file changes, and the docs label is prioritized in our release notes over tests. This means that the docs sections of the notes often contained many tests changes.

Solution: Prioritize the test label first over docs to hopefully better organize release notes.
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: Many of our test changes also include markdown file changes, and the docs label is prioritized in our release notes over tests. This means that the docs sections of the notes often contained many tests changes.

Solution: Prioritize the test label first over docs to hopefully better organize release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants