- 
                Notifications
    You must be signed in to change notification settings 
- Fork 141
CP/DP Split: provision NGINX Plus #3148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            sjberman
  merged 4 commits into
  nginx:change/control-data-plane-split
from
sjberman:chore/provision-nginx-plus
  
      
      
   
  Feb 25, 2025 
      
    
                
     Merged
            
            CP/DP Split: provision NGINX Plus #3148
                    sjberman
  merged 4 commits into
  nginx:change/control-data-plane-split
from
sjberman:chore/provision-nginx-plus
  
      
      
   
  Feb 25, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    bjee19
  
              
              requested changes
              
                  
                    Feb 20, 2025 
                  
              
              
            
            
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace. Added unit tests.
f9faeca    to
    ff1989e      
    Compare
  
    
              
                    bjee19
  
              
              approved these changes
              
                  
                    Feb 21, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
              
                    salonichf5
  
              
              reviewed
              
                  
                    Feb 24, 2025 
                  
              
              
            
            
              
                    salonichf5
  
              
              reviewed
              
                  
                    Feb 24, 2025 
                  
              
              
            
            
              
                    salonichf5
  
              
              approved these changes
              
                  
                    Feb 24, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
3cbd175
      into
      
  
    nginx:change/control-data-plane-split
  
    
        24 of 25 checks passed
      
      
    
  sjberman 
      added a commit
      that referenced
      this pull request
    
      Feb 25, 2025 
    
    
      
  
    
      
    
  
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace. Added unit tests.
    
  sjberman 
      added a commit
      that referenced
      this pull request
    
      Mar 4, 2025 
    
    
      
  
    
      
    
  
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace. Added unit tests.
    
  sjberman 
      added a commit
      that referenced
      this pull request
    
      Apr 23, 2025 
    
    
      
  
    
      
    
  
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace. Added unit tests.
    
  sjberman 
      added a commit
      that referenced
      this pull request
    
      May 6, 2025 
    
    
      
  
    
      
    
  
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace. Added unit tests.
    
  sjberman 
      added a commit
      that referenced
      this pull request
    
      May 14, 2025 
    
    
      
  
    
      
    
  
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace. Added unit tests.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Continuation from the previous commit to add support for provisioning with NGINX Plus. This adds support for duplicating any NGINX Plus or docker registry secrets into the Gateway namespace.
Added unit tests.
Testing: Manually deployed using NGINX Plus. All secrets were created and managed properly.
Closes #2844