CP/DP Split: handle kill signal #3260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3260 +/- ##
===================================================================
- Coverage 89.74% 86.79% -2.96%
===================================================================
Files 109 124 +15
Lines 11150 14292 +3142
Branches 50 62 +12
===================================================================
+ Hits 10007 12405 +2398
- Misses 1083 1751 +668
- Partials 60 136 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salonichf5
approved these changes
Mar 28, 2025
bjee19
approved these changes
Mar 31, 2025
Problem: The data plane container was not properly handling the kill signal when the Pod was Terminated. Solution: Update the entrypoint to catch the proper signals.
sjberman
merged commit de0fdc2
into
change/control-data-plane-split
28 of 37 checks passed
sjberman
added a commit
that referenced
this pull request
Apr 23, 2025
Problem: The data plane container was not properly handling the kill signal when the Pod was Terminated. Solution: Update the entrypoint to catch the proper signals.
sjberman
added a commit
that referenced
this pull request
May 6, 2025
Problem: The data plane container was not properly handling the kill signal when the Pod was Terminated. Solution: Update the entrypoint to catch the proper signals.
sjberman
added a commit
that referenced
this pull request
May 14, 2025
Problem: The data plane container was not properly handling the kill signal when the Pod was Terminated. Solution: Update the entrypoint to catch the proper signals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The data plane container was not properly handling the kill signal when the Pod was Terminated.
Solution: Update the entrypoint to catch the proper signals.
Testing: Verified that the Pod is terminated immediately instead of hanging.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.