CP/DP Split: Openshift support #3278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Now that we have additional pods in the new architecture, we need the proper SecurityContextConstraints for running in Openshift. Solution: Create an SCC for the cert-generator and an SCC for nginx data plane pods on startup. A Role and RoleBinding are created when deploying nginx to link to the SCC.
github-actions
bot
added
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3278 +/- ##
===================================================================
- Coverage 89.74% 86.50% -3.25%
===================================================================
Files 109 125 +16
Lines 11150 14453 +3303
Branches 50 62 +12
===================================================================
+ Hits 10007 12502 +2495
- Misses 1083 1813 +730
- Partials 60 138 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjee19
reviewed
Apr 1, 2025
bjee19
approved these changes
Apr 2, 2025
salonichf5
approved these changes
Apr 7, 2025
sjberman
merged commit e6cae12
into
change/control-data-plane-split
35 of 44 checks passed
sjberman
added a commit
that referenced
this pull request
Apr 23, 2025
Problem: Now that we have additional pods in the new architecture, we need the proper SecurityContextConstraints for running in Openshift. Solution: Create an SCC for the cert-generator and an SCC for nginx data plane pods on startup. A Role and RoleBinding are created when deploying nginx to link to the SCC.
sjberman
added a commit
that referenced
this pull request
May 6, 2025
Problem: Now that we have additional pods in the new architecture, we need the proper SecurityContextConstraints for running in Openshift. Solution: Create an SCC for the cert-generator and an SCC for nginx data plane pods on startup. A Role and RoleBinding are created when deploying nginx to link to the SCC.
sjberman
added a commit
that referenced
this pull request
May 14, 2025
Problem: Now that we have additional pods in the new architecture, we need the proper SecurityContextConstraints for running in Openshift. Solution: Create an SCC for the cert-generator and an SCC for nginx data plane pods on startup. A Role and RoleBinding are created when deploying nginx to link to the SCC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Now that we have additional pods in the new architecture, we need the proper SecurityContextConstraints for running in Openshift.
Solution: Create an SCC for the cert-generator and an SCC for nginx data plane pods on startup. A Role and RoleBinding are created when deploying nginx to link to the SCC.
Testing: Verified that all objects are created and running with the proper permissions in OpenShift.
Closes #3064
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.