Build WAF image in pipeline #3565
Conversation
* Add WAF dockerfile and make targets * Add WAF parameters to NGINXProxy resource * Review feedback * Add plus image path; add readOnlyRootFS to waf containers * Capitalise WAF
Problem: As a user of NGF with an NGINX One subscription I want a method to configure WAF protection on my Gateways and Routes So that I can enable the NAP WAF feature for the applications that need it. Solution: Define the WafPolicy CRD. Co-authored-by: Ciara Stacke <[email protected]>
ciarams87
force-pushed
the
chore/build-image-pipeline
branch
from
d21f15b to
b4a6a0b
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ciarams87
force-pushed
the
chore/build-image-pipeline
branch
from
4500d38 to
e40b61f
Compare
| defaultImagePullPolicy = corev1.PullIfNotPresent | ||
| defaultNginxImagePath = "ghcr.io/nginx/nginx-gateway-fabric/nginx" | ||
| defaultNginxPlusImagePath = "private-registry.nginx.com/nginx-gateway-fabric/nginx-plus" | ||
| defaultNginxPlusWafImagePath = "private-registry.nginx.com/nginx-gateway-fabric/nginx-plus-nap-waf" |
There was a problem hiding this comment.
maybe I am overthinking this but shouldn't the image names be same in pipeline and these defaults?
why is it plus-waf in workflows and different here?
There was a problem hiding this comment.
Oh, this is still a draft, I haven't finalised the image names with the team managing the registry yet! I just need a PR to make sure the pipeline is working, sorry for the confusion!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/nap-waf #3565 +/- ##
================================================
+ Coverage 86.83% 95.19% +8.36%
================================================
Files 127 1 -126
Lines 15079 229 -14850
Branches 62 62
================================================
- Hits 13094 218 -12876
+ Misses 1835 11 -1824
+ Partials 150 0 -150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Proposed changes
Problem: The NGINX Plus NAP WAF image is not being built in the pipeline
Solution: Extend the workflow to build the image in the pipeline
Partially implements #3452
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.