Skip to content

Update remaining server side apply for crds #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Aug 8, 2025

Update remaining server side apply for crds, remaining one was in the upgrade nfr test.

@bjee19 bjee19 requested a review from a team as a code owner August 8, 2025 17:59
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Aug 8, 2025
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.92%. Comparing base (924252b) to head (509f206).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3711      +/-   ##
==========================================
- Coverage   95.19%   86.92%   -8.28%     
==========================================
  Files           1      128     +127     
  Lines         229    15962   +15733     
  Branches       62       62              
==========================================
+ Hits          218    13875   +13657     
- Misses         11     1920    +1909     
- Partials        0      167     +167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19 bjee19 enabled auto-merge (squash) August 8, 2025 18:18
@sjberman sjberman disabled auto-merge August 8, 2025 18:31
@bjee19 bjee19 enabled auto-merge (squash) August 8, 2025 18:41
@bjee19 bjee19 merged commit 00112a4 into main Aug 8, 2025
65 of 66 checks passed
@bjee19 bjee19 deleted the chore/update-remaining-server-side-apply branch August 8, 2025 19:16
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants