(Cherry-pick) Fix NFR tests (#3722) #3723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFR tests were having some issues regarding applying the NginxProxy CRD and timing out when deleting the test namespace while cleaning up resources. Fixed the CRD issues by applying with additional flag and increased deletion namespace timeout.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.1 #3723 +/- ##
===============================================
- Coverage 86.95% 86.91% -0.04%
===============================================
Files 128 128
Lines 15962 15962
Branches 62 62
===============================================
- Hits 13879 13873 -6
- Misses 1917 1921 +4
- Partials 166 168 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sarthyparty
approved these changes
Aug 12, 2025
sjberman
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #3722