Skip to content

Add readiness probes to deployments in functional tests #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarthyparty
Copy link
Contributor

Proposed changes

Problem: Functional tests failed inconsistently, due to deployments and pods not be ready.

Solution: Added readiness probes to all deployments.

Testing: N/A

Closes #1866

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@sarthyparty sarthyparty requested a review from a team as a code owner August 14, 2025 18:14
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 14, 2025
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.94%. Comparing base (a82c2ba) to head (e9e1178).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3740      +/-   ##
==========================================
- Coverage   86.95%   86.94%   -0.01%     
==========================================
  Files         128      128              
  Lines       15986    15986              
  Branches       62       62              
==========================================
- Hits        13900    13899       -1     
- Misses       1919     1921       +2     
+ Partials      167      166       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19
Copy link
Contributor

bjee19 commented Aug 14, 2025

For testing can you run the functional tests locally a few times (i know the pipeline runs it 4 times) to make sure there aren't any flakey situations? Also can you verify the readiness probes are applied in the deployments when the tests are running?

@sarthyparty
Copy link
Contributor Author

sarthyparty commented Aug 14, 2025

@bjee19 After running them several times, the tracing test failed once. I'm not sure how to fix it, as there are readiness probes and we are waiting for them to be ready. It's mentioned in a comment here

@bjee19
Copy link
Contributor

bjee19 commented Aug 14, 2025

@sarthyparty Yea that looks like its probably not an issue with the example apps not being ready in time (something that wouldn't get fixed with the readiness probes) so the other tests passing consistently is good. Were you also able to verify the readiness probes in the deployment yaml as the apps were rolling out?

@sarthyparty
Copy link
Contributor Author

I saw the readiness probe on the pod and deployment when I described them

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this updates the probes in the NFRs too, but i think thats fine/better. nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Add retries in functional tests
2 participants