add nginx image version validation during agent connections #3928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3928 +/- ##
==========================================
- Coverage 86.84% 86.79% -0.06%
==========================================
Files 128 128
Lines 16559 16602 +43
Branches 62 62
==========================================
+ Hits 14381 14410 +29
- Misses 1998 2009 +11
- Partials 180 183 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjberman
reviewed
Sep 17, 2025
ciarams87
force-pushed
the
bug/mismatch-config
branch
2 times, most recently
from
b591565 to
7b62325
Compare
sjberman
reviewed
Sep 22, 2025
sjberman
reviewed
Sep 23, 2025
sjberman
reviewed
Sep 23, 2025
ciarams87
force-pushed
the
bug/mismatch-config
branch
from
043f1f0 to
2566561
Compare
sjberman
approved these changes
Sep 23, 2025
bjee19
reviewed
Sep 23, 2025
|
nit: since this is a bugfix, we don't need |
bjee19
approved these changes
Sep 24, 2025
ciarams87
force-pushed
the
bug/mismatch-config
branch
from
2566561 to
86734c1
Compare
ciarams87
changed the title
salonichf5
pushed a commit
that referenced
this pull request
Sep 24, 2025
Problem: During an NGF upgrade, the new version of the control plane will send a configuration to the old version of the nginx data plane, before the nginx data plane is updated to the new version. This can cause incompatibility issues for a brief amount of time, which could cause disruptions. Solution: Implement version validation by ensuring the pod image matches the image in the current deployment/ daemonset spec to prevent configuration from being sent to nginx data plane pods still running the previous image version during upgrades.
6 tasks
salonichf5
pushed a commit
that referenced
this pull request
Sep 24, 2025
Problem: During an NGF upgrade, the new version of the control plane will send a configuration to the old version of the nginx data plane, before the nginx data plane is updated to the new version. This can cause incompatibility issues for a brief amount of time, which could cause disruptions. Solution: Implement version validation by ensuring the pod image matches the image in the current deployment/ daemonset spec to prevent configuration from being sent to nginx data plane pods still running the previous image version during upgrades.
salonichf5
added a commit
that referenced
this pull request
Sep 24, 2025
…3953) Problem: During an NGF upgrade, the new version of the control plane will send a configuration to the old version of the nginx data plane, before the nginx data plane is updated to the new version. This can cause incompatibility issues for a brief amount of time, which could cause disruptions. Solution: Implement version validation by ensuring the pod image matches the image in the current deployment/ daemonset spec to prevent configuration from being sent to nginx data plane pods still running the previous image version during upgrades. Co-authored-by: Ciara Stacke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: During an NGF upgrade, the new version of the control plane will send a configuration to the old version of the nginx data plane, before the nginx data plane is updated to the new version. This can cause incompatibility issues for a brief amount of time, which could cause disruptions.
Solution: Implement version validation by ensuring the pod image matches the image in the current deployment/ daemonset spec to prevent configuration from being sent to nginx data plane pods still running the previous image version during upgrades.
Testing: Manually tested upgrading in a cluster and verified that we don't send config to pods still running the previous image version
Closes #3867
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.