Skip to content

Conversation

@ciarams87
Copy link
Contributor

Problem: Need to allow disabling cert-generator with a Helm value.

Solution: Allow disabling cert-generator with a Helm value.

Testing: Allow disabling cert-generator with a Helm value.

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: Need to allow disabling cert-generator with a Helm value.

Solution: Allow disabling cert-generator with a Helm value.

Testing: Allow disabling cert-generator with a Helm value.
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (dd60012) to head (731b51f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4216      +/-   ##
==========================================
- Coverage   86.02%   86.00%   -0.03%     
==========================================
  Files         131      131              
  Lines       14111    14111              
  Branches       35       35              
==========================================
- Hits        12139    12136       -3     
- Misses       1770     1772       +2     
- Partials      202      203       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 changed the title Allow disabling cert-generator with a Helm value DO NOT MERGE - shadow PR for pipeline on fork Nov 5, 2025
@ciarams87 ciarams87 closed this Nov 5, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 5, 2025
@sjberman sjberman deleted the temp/allow_disabling_cert_generator branch November 21, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation helm-chart Relates to helm chart

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants