Skip to content

Commit 125f1bb

Browse files
authored
Update labels, annotations, and last version (#12)
* Update labels, annotations, and last version * Add resources for IC deployment * Result of make bundle
1 parent 03614b9 commit 125f1bb

File tree

9 files changed

+52
-23
lines changed

9 files changed

+52
-23
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ Learn more about operators in the [Kubernetes Documentation](https://kubernetes.
88

99
To install a specific version of the NGINX Ingress Controller with the operator, a specific version of the NGINX Ingress Operator is required.
1010

11-
Up until version 0.5.0, this Operator was Go based. Version 1.0.0 marks an uncompatible upgrade as this release swtiched the Operator to being Helm-based, built from the [NGINX Ingress Controller Helm chart](http://helm.nginx.com/#nginx-ingress-controller). The configuration for the Helm chart can be seen in the [NGINX Ingress Controller documentation](https://docs.nginx.com/nginx-ingress-controller/installation/installation-with-helm/#configuration).
11+
Up until version 0.5.1, this Operator was Go based. Version 1.0.0 marks an uncompatible upgrade as this release swtiched the Operator to being Helm-based, built from the [NGINX Ingress Controller Helm chart](http://helm.nginx.com/#nginx-ingress-controller). The configuration for the Helm chart can be seen in the [NGINX Ingress Controller documentation](https://docs.nginx.com/nginx-ingress-controller/installation/installation-with-helm/#configuration).
1212

1313
The following table shows the relation between the versions of the two projects:
1414

1515
| NGINX Ingress Controller | NGINX Ingress Operator |
1616
| --- | --- |
1717
| 2.2.x | 1.0.0 |
18-
| 2.1.x | 0.5.0 |
18+
| 2.1.x | 0.5.1 |
1919
| 2.0.x | 0.4.0 |
2020
| 1.12.x | 0.3.0 |
2121
| 1.11.x | 0.2.0 |

bundle.Dockerfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,7 @@ LABEL operators.operatorframework.io.test.config.v1=tests/scorecard/
1919
COPY bundle/manifests /manifests/
2020
COPY bundle/metadata /metadata/
2121
COPY bundle/tests/scorecard /tests/scorecard/
22+
23+
LABEL com.redhat.openshift.versions="v4.6"
24+
LABEL com.redhat.delivery.operator.bundle=true
25+
LABEL com.redhat.delivery.backport=true

bundle/manifests/nginx-ingress-operator.clusterserviceversion.yaml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,12 @@ metadata:
8080
"enableLeaderElection": true,
8181
"ingressLink": ""
8282
},
83-
"resources": {},
83+
"resources": {
84+
"requests": {
85+
"cpu": "100m",
86+
"memory": "128Mi"
87+
}
88+
},
8489
"service": {
8590
"annotations": {},
8691
"create": true,
@@ -137,12 +142,18 @@ metadata:
137142
categories: Monitoring, Networking
138143
certified: "true"
139144
containerImage: nginx/nginx-ingress-operator:1.0.0
145+
createdAt: placeholder
140146
description: The NGINX Ingress Operator is a Kubernetes/OpenShift component which
141147
deploys and manages one or more NGINX/NGINX Plus Ingress Controllers
148+
operatorframework.io/suggested-namespace: nginx-ingress
142149
operators.operatorframework.io/builder: operator-sdk-v1.16.0-ocp
143150
operators.operatorframework.io/project_layout: helm.sdk.operatorframework.io/v1
144151
repository: https://github.com/nginxinc/nginx-ingress-helm-operator
145152
support: NGINX Inc.
153+
labels:
154+
operatorframework.io/arch.amd64: supported
155+
operatorframework.io/arch.ppc64le: supported
156+
operatorframework.io/arch.s390x: supported
146157
name: nginx-ingress-operator.v1.0.0
147158
namespace: placeholder
148159
spec:
@@ -280,7 +291,9 @@ spec:
280291
- create
281292
serviceAccountName: nginx-ingress-operator-controller-manager
282293
deployments:
283-
- name: nginx-ingress-operator-controller-manager
294+
- label:
295+
control-plane: controller-manager
296+
name: nginx-ingress-operator-controller-manager
284297
spec:
285298
replicas: 1
286299
selector:

config/manifests/bases/nginx-ingress-operator.clusterserviceversion.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,14 +132,20 @@ metadata:
132132
categories: Monitoring, Networking
133133
certified: "true"
134134
containerImage: nginx/nginx-ingress-operator:1.0.0
135+
createdAt: placeholder
135136
description: The NGINX Ingress Operator is a Kubernetes/OpenShift component which
136137
deploys and manages one or more NGINX/NGINX Plus Ingress Controllers
138+
operatorframework.io/suggested-namespace: nginx-ingress
137139
operators.operatorframework.io/builder: operator-sdk-v1.16.0-ocp
138140
operators.operatorframework.io/project_layout: helm.sdk.operatorframework.io/v1
139141
repository: https://github.com/nginxinc/nginx-ingress-helm-operator
140142
support: NGINX Inc.
141-
name: nginx-ingress-operator.v1.0.0
142-
namespace: openshift-operators
143+
labels:
144+
operatorframework.io/arch.amd64: supported
145+
operatorframework.io/arch.ppc64le: supported
146+
operatorframework.io/arch.s390x: supported
147+
name: nginx-ingress-operator.v0.0.0
148+
namespace: placeholder
143149
spec:
144150
apiservicedefinitions: {}
145151
customresourcedefinitions:

config/samples/charts_v1alpha1_nginxingress.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,10 @@ spec:
6363
enable: true
6464
enableLeaderElection: true
6565
ingressLink: ""
66-
resources: {}
66+
resources:
67+
requests:
68+
cpu: 100m
69+
memory: 128Mi
6770
service:
6871
annotations: {}
6972
create: true

docs/nginx-ingress-controller.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,10 @@ spec:
7373
enable: true
7474
enableLeaderElection: true
7575
ingressLink: ""
76-
resources: {}
76+
resources:
77+
requests:
78+
cpu: 100m
79+
memory: 128Mi
7780
service:
7881
annotations: {}
7982
create: true
@@ -139,7 +142,7 @@ Parameter | Description | Default
139142
`controller.volumeMounts` | The volumeMounts of the Ingress Controller pods. | []
140143
`controller.initContainers` | InitContainers for the Ingress Controller pods. | []
141144
`controller.extraContainers` | Extra (eg. sidecar) containers for the Ingress Controller pods. | []
142-
`controller.resources` | The resources of the Ingress Controller pods. | {}
145+
`controller.resources` | The resources of the Ingress Controller pods. | requests: cpu=100m,memory=128Mi
143146
`controller.replicaCount` | The number of replicas of the Ingress Controller deployment. | 1
144147
`controller.ingressClass` | A class of the Ingress Controller. An IngressClass resource with the name equal to the class must be deployed. Otherwise, the Ingress Controller will fail to start. The Ingress Controller only processes resources that belong to its class - i.e. have the "ingressClassName" field resource equal to the class. The Ingress Controller processes all the VirtualServer/VirtualServerRoute/TransportServer resources that do not have the "ingressClassName" field for all versions of kubernetes. | nginx
145148
`controller.setAsDefaultIngress` | New Ingresses without an `"ingressClassName"` field specified will be assigned the class specified in `controller.ingressClass`. | false

docs/upgrades.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# Upgrade - 0.5.0 to 1.0.0
1+
# Upgrade - 0.5.1 to 1.0.0
22

3-
Release 1.0.0 includes a backward incompatible change from version 0.5.0 as we have moved from a Go based operator to a Helm based operator.
3+
Release 1.0.0 includes a backward incompatible change from version 0.5.1 as we have moved from a Go based operator to a Helm based operator.
44

5-
## OLM upgrade - 0.5.0 to 1.0.0
5+
## OLM upgrade - 0.5.1 to 1.0.0
66

77
**Note: The `nginx-ingress-operator` supports `Basic Install` only - we do not support auto-updates. When you are installing the Operator using the OLM, the auto-update feature should be disabled to avoid breaking changes being auto-applied. In OpenShift, this can be done by setting the `Approval Strategy` to `Manual`. Please see the [Operator SDK docs](https://sdk.operatorframework.io/docs/advanced-topics/operator-capabilities/operator-capabilities/) for more details on the Operator Capability Levels.**
88
1. Upgrade CRDs
@@ -17,7 +17,7 @@ Release 1.0.0 includes a backward incompatible change from version 0.5.0 as we h
1717

1818
Navigate [here](../helm-charts/nginx-ingress/) and run ` kubectl apply -f crds/`
1919

20-
### 1. Uninstall the existing 0.5.0 operator, the nginx ingress controller CRD, and the ingressClass
20+
### 1. Uninstall the existing 0.5.1 operator, the nginx ingress controller CRD, and the ingressClass
2121

2222
Uninstall the operator using the web console - see [the OCP documentation for details](https://access.redhat.com/documentation/en-us/openshift_container_platform/4.9/pdf/operators/OpenShift_Container_Platform-4.9-Operators-en-US.pdf).
2323

@@ -33,7 +33,7 @@ Install the latest version of the Operator following the steps outlined in [Open
3333

3434
Use the new Nginx Ingress Operator installation to deploy Nginx Ingress Controller - see the release notes [here](https://docs.nginx.com/nginx-ingress-controller/releases/#nginx-ingress-controller-2-2-0) and a guide to the Helm configuration parameters [here](https://docs.nginx.com/nginx-ingress-controller/installation/installation-with-helm/#configuration)
3535

36-
## Manual upgrade - 0.5.0 to 1.0.0
36+
## Manual upgrade - 0.5.1 to 1.0.0
3737

3838
### 1. Deploy the new operator
3939

@@ -43,7 +43,7 @@ Deploy the operator following the steps outlined in [manual installation doc](./
4343

4444
Uninstall the existing operator deployment:
4545

46-
1. Checkout the previous version of the nginx-ingress-operator [0.5.0](https://github.com/nginxinc/nginx-ingress-helm-operator/releases/tag/v0.5.0).
46+
1. Checkout the previous version of the nginx-ingress-operator [0.5.1](https://github.com/nginxinc/nginx-ingress-helm-operator/releases/tag/v0.5.0).
4747
2. Uninstall the resources by running the following command:
4848
```
4949
make undeploy

helm-charts/nginx-ingress/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ Parameter | Description | Default
176176
`controller.volumeMounts` | The volumeMounts of the Ingress Controller pods. | []
177177
`controller.initContainers` | InitContainers for the Ingress Controller pods. | []
178178
`controller.extraContainers` | Extra (eg. sidecar) containers for the Ingress Controller pods. | []
179-
`controller.resources` | The resources of the Ingress Controller pods. | {}
179+
`controller.resources` | The resources of the Ingress Controller pods. | requests: cpu=100m,memory=128Mi
180180
`controller.replicaCount` | The number of replicas of the Ingress Controller deployment. | 1
181181
`controller.ingressClass` | A class of the Ingress Controller. An IngressClass resource with the name equal to the class must be deployed. Otherwise, the Ingress Controller will fail to start. The Ingress Controller only processes resources that belong to its class - i.e. have the "ingressClassName" field resource equal to the class. The Ingress Controller processes all the VirtualServer/VirtualServerRoute/TransportServer resources that do not have the "ingressClassName" field for all versions of kubernetes. | nginx
182182
`controller.setAsDefaultIngress` | New Ingresses without an `"ingressClassName"` field specified will be assigned the class specified in `controller.ingressClass`. | false

helm-charts/nginx-ingress/values.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,13 @@ controller:
103103
terminationGracePeriodSeconds: 30
104104

105105
## The resources of the Ingress Controller pods.
106-
resources: {}
107-
# limits:
108-
# cpu: 100m
109-
# memory: 64Mi
110-
# requests:
111-
# cpu: 100m
112-
# memory: 64Mi
106+
resources:
107+
requests:
108+
cpu: 100m
109+
memory: 128Mi
110+
# limits:
111+
# cpu: 1
112+
# memory: 1Gi
113113

114114
## The tolerations of the Ingress Controller pods.
115115
tolerations: []

0 commit comments

Comments
 (0)