@@ -627,55 +627,62 @@ func TestClientWithMaxAPI(t *testing.T) {
627
627
t .Parallel ()
628
628
629
629
tests := []struct {
630
+ name string
630
631
apiVersions string
631
632
expected int
632
633
}{
633
634
{
635
+ name : "Test 1: API versions contains invalid version" ,
634
636
apiVersions : `[4, 5, 6, 7, 8, 9, 25]` ,
635
637
expected : APIVersion ,
636
638
},
637
639
{
640
+ name : "Test 2: No API versions, default API Version is used" ,
638
641
apiVersions : `` ,
639
642
expected : APIVersion ,
640
643
},
641
644
{
645
+ name : "Test 3: API version lower than default" ,
642
646
apiVersions : `[4, 5, 6, 7]` ,
643
647
expected : 7 ,
644
648
},
645
649
{
650
+ name : "Test 4: No API versions, default API version is used" ,
646
651
apiVersions : `[""]` ,
647
652
expected : APIVersion ,
648
653
},
649
654
}
650
655
651
- for _ , test := range tests {
652
- // Test creating a new client with max API version
653
- ts := httptest .NewServer (http .HandlerFunc (func (w http.ResponseWriter , r * http.Request ) {
654
- switch {
655
- case r .RequestURI == "/" :
656
- _ , err := w .Write ([]byte (test .apiVersions ))
657
- if err != nil {
658
- t .Fatalf ("unexpected error: %v" , err )
659
- }
660
- default :
661
- _ , err := w .Write ([]byte (`{}` ))
662
- if err != nil {
663
- t .Fatalf ("unexpected error: %v" , err )
656
+ for _ , tt := range tests {
657
+ t .Run (tt .name , func (t * testing.T ) {
658
+ // Test creating a new client with max API version
659
+ ts := httptest .NewServer (http .HandlerFunc (func (w http.ResponseWriter , r * http.Request ) {
660
+ switch {
661
+ case r .RequestURI == "/" :
662
+ _ , err := w .Write ([]byte (tt .apiVersions ))
663
+ if err != nil {
664
+ t .Fatalf ("unexpected error: %v" , err )
665
+ }
666
+ default :
667
+ _ , err := w .Write ([]byte (`{}` ))
668
+ if err != nil {
669
+ t .Fatalf ("unexpected error: %v" , err )
670
+ }
664
671
}
665
- }
666
- }))
667
- defer ts .Close ()
672
+ }))
673
+ defer ts .Close ()
668
674
669
- client , err := NewNginxClient (ts .URL , WithMaxAPIVersion ())
670
- if err != nil {
671
- t .Fatalf ("unexpected error: %v" , err )
672
- }
673
- if client == nil {
674
- t .Fatalf ("client is nil" )
675
- }
676
- if client .apiVersion != test .expected {
677
- t .Fatalf ("expected client.apiVersion to be %v, but got %v" , test .expected , client .apiVersion )
678
- }
675
+ client , err := NewNginxClient (ts .URL , WithMaxAPIVersion ())
676
+ if err != nil {
677
+ t .Fatalf ("unexpected error: %v" , err )
678
+ }
679
+ if client == nil {
680
+ t .Fatalf ("client is nil" )
681
+ }
682
+ if client .apiVersion != tt .expected {
683
+ t .Fatalf ("expected client.apiVersion to be %v, but got %v" , tt .expected , client .apiVersion )
684
+ }
685
+ })
679
686
}
680
687
}
681
688
0 commit comments