Add golangci-lint as a dependency (#176)

Author: lucacome

.github/workflows/lint.yml

@@ -17,7 +17,6 @@ defaults:
     shell: bash
 
 env:
-  GOLANGCI_VERSION: 1.38
   GOLANGCI_TIMEOUT: 10m0s
 
 jobs:
@@ -31,5 +30,4 @@ jobs:
       - name: Lint Code
         uses: golangci/[email protected]
         with:
-          version: 'v${{ env.GOLANGCI_VERSION }}'
           args: --timeout ${{ env.GOLANGCI_TIMEOUT }} --issues-exit-code=0

.golangci.yml

@@ -0,0 +1,17 @@
+linters-settings:
+  misspell:
+    locale: US
+
+linters:
+    enable:
+    - goimports
+    - gosimple
+    - govet
+    - misspell
+    - gofmt
+    - unparam
+    - unconvert
+    - structcheck
+    - errcheck
+    disable-all: true
+

Makefile

@@ -6,8 +6,6 @@ DOCKERFILEPATH = build
 DOCKERFILE = Dockerfile
 
 GIT_COMMIT = $(shell git rev-parse HEAD)
-
-GOLANGCI_CONTAINER=golangci/golangci-lint:v1.29-alpine
 DATE = $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
 
 export DOCKER_BUILDKIT = 1
@@ -18,10 +16,7 @@ nginx-prometheus-exporter:
 
 .PHONY: lint
 lint:
-	docker run --rm \
-	-v $(shell pwd):/go/src/github.com/nginxinc/nginx-prometheus-exporter \
-	-w /go/src/github.com/nginxinc/nginx-prometheus-exporter \
-	$(GOLANGCI_CONTAINER) golangci-lint run
+	go run github.com/golangci/golangci-lint/cmd/golangci-lint run
 
 .PHONY: test
 test:
@@ -35,6 +30,10 @@ container:
 push: container
 	docker push $(PREFIX):$(TAG)
 
+.PHONY: deps
+deps:
+	@go mod tidy && go mod verify && go mod download
+
 .PHONY: clean
 clean:
 	-rm -r dist

go.mod

@@ -3,8 +3,8 @@ module github.com/nginxinc/nginx-prometheus-exporter
 go 1.16
 
 require (
+	github.com/golangci/golangci-lint v1.39.0
 	github.com/nginxinc/nginx-plus-go-client v0.8.0
 	github.com/prometheus/client_golang v1.10.0
 	github.com/prometheus/common v0.20.0
-	google.golang.org/protobuf v1.26.0 // indirect
 )