Add lint option to Makefile and fix lint issues

Rulox · Rulox · commit 4ef2b3467264 · 2019-03-21T19:24:14.000Z
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -64,3 +64,4 @@ Note: if you’d like to implement a new feature, please consider creating a fea
 * Run `gofmt` over your code to automatically resolve a lot of style issues. Most editors support this running automatically when saving a code file.
 * Run `go lint` and `go vet` on your code too to catch any other issues.
 * Follow this guide on some good practice and idioms for Go -  https://github.com/golang/go/wiki/CodeReviewComments
+* To check for extra issues, install [golangci-lint](https://github.com/golangci/golangci-lint) and run `make lint` or `golangci-lint run`
diff --git a/Makefile b/Makefile
@@ -8,6 +8,9 @@ BUILD_DIR = build_output
 nginx-prometheus-exporter: test
 	CGO_ENABLED=0 go build -installsuffix cgo -ldflags "-X main.version=$(VERSION) -X main.gitCommit=$(GIT_COMMIT)" -o nginx-prometheus-exporter 
 
+lint:
+	golangci-lint run
+
 test:
 	go test ./...
 
diff --git a/exporter.go b/exporter.go
@@ -176,13 +176,16 @@ func main() {
 	}
 	http.Handle(*metricsPath, promhttp.HandlerFor(registry, promhttp.HandlerOpts{}))
 	http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
-		w.Write([]byte(`<html>
+		_, err := w.Write([]byte(`<html>
 			<head><title>NGINX Exporter</title></head>
 			<body>
 			<h1>NGINX Exporter</h1>
 			<p><a href='/metrics'>Metrics</a></p>
 			</body>
 			</html>`))
+		if err != nil {
+			log.Printf("Error while sending a response for the '/' path: %v", err)
+		}
 	})
 	log.Printf("NGINX Prometheus Exporter has successfully started")
 	log.Fatal(http.ListenAndServe(*listenAddr, nil))
