Skip to content

Commit c880254

Browse files
committed
Address review comments
1 parent 7e8eb6c commit c880254

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

exporter.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,9 +262,9 @@ func registerCollector(logger *slog.Logger, transport *http.Transport,
262262
remoteAddr := conn.RemoteAddr()
263263
transportProtocol := proxyproto.TCPv4
264264

265-
switch addr := remoteAddr.(type) {
265+
switch remoteAddrTyped := remoteAddr.(type) {
266266
case *net.TCPAddr:
267-
if addr.IP.To4() == nil {
267+
if remoteAddrTyped.IP.To4() == nil {
268268
transportProtocol = proxyproto.TCPv6
269269
}
270270
case *net.UnixAddr:
@@ -279,6 +279,7 @@ func registerCollector(logger *slog.Logger, transport *http.Transport,
279279
DestinationAddr: remoteAddr,
280280
}
281281

282+
// as we do not use any TLVs, header size should be pretty small, hence we only check for error, assuming the whole header went out in a single packet
282283
_, err = header.WriteTo(conn)
283284
if err != nil {
284285
return nil, fmt.Errorf("writing proxyproto header: %w", err)

0 commit comments

Comments
 (0)