Skip to content

Switch to DialContext() to address lint issue #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2025
Merged

Switch to DialContext() to address lint issue #1107

merged 5 commits into from
Aug 8, 2025

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 7, 2025 •
edited
Loading

Proposed changes

Address lint issue

  Error: exporter.go:234:19: net.Dial must not be called. use (*net.Dialer).DialContext (noctx)
  			return net.Dial("unix", socketPath)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 7, 2025 10:22
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 7, 2025
@pdabelf5 pdabelf5 moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller Aug 7, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.30%. Comparing base (3872026) to head (4a390b2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main   #1107      +/-   ##
========================================
- Coverage   4.31%   4.30%   -0.01%     
========================================
  Files          5       5              
  Lines       1438    1439       +1     
========================================
  Hits          62      62              
- Misses      1376    1377       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pdabelf5 pdabelf5 added this to the v1.5.0 milestone Aug 7, 2025
@pdabelf5 pdabelf5 self-assigned this Aug 8, 2025
@pdabelf5 pdabelf5 merged commit cb3b8c4 into main Aug 8, 2025
14 of 15 checks passed
@pdabelf5 pdabelf5 deleted the chore/address-lint branch August 8, 2025 14:28
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javorszky javorszky javorszky approved these changes

@vepatel vepatel vepatel approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @javorszky @vepatel