Skip to content

Commit ac7043b

Browse files
committed
chore: resolve PR comments
1 parent 23ccd4f commit ac7043b

File tree

9 files changed

+16
-32
lines changed

9 files changed

+16
-32
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
# Main global owner #
33
#####################
44

5-
*
5+
*

.github/ISSUE_TEMPLATE/bug_report.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ body:
1616
**Note:** If you are seeking community support or have a question, please consider starting a new thread via [GitHub discussions][discussions] or the [NGINX Community forum][forum].
1717
1818
[issue search]: https://github.com/nginx/nginx-s3-gateway/issues
19-
2019
[discussions]: https://github.com/nginx/nginx-s3-gateway/discussions
2120
[forum]: https://community.nginx.org
2221
@@ -53,13 +52,13 @@ body:
5352
label: Environment Details
5453
description: Please provide details about your environment.
5554
value: |
56-
- Version of the S3 container used (when downloaded from either Docker Hub or the GitHub Container Registry)
57-
- Version of this project or specific commit when building your own S3 container
58-
- Version of NGINX Open Source or NGINX Plus (OSS/Plus)
59-
- Version of NGINX JavaScript
60-
- Target deployment platform for the S3 container
61-
- S3 backend implementation (AWS, Ceph, NetApp StorageGrid, etc...)
62-
- Authentication method (IAM, IAM with Fargate, IAM with K8S, AWS Credentials, etc...)
55+
- Version of the S3 container used (DockerHub/GCR):
56+
- Commit/Tag (If Building from Source):
57+
- Version of NGINX Open Source or NGINX Plus: [OSS/Plus]
58+
- Version of NGINX JavaScript:
59+
- Target deployment platforms [e.g. AWS/GCP/local cluster/etc...]:
60+
- S3 backend implementation: [e.g. AWS, Ceph, NetApp StorageGrid, etc...]
61+
- Authentication method: [IAM, IAM with Fargate, IAM with K8S, AWS Credentials, etc...]
6362
validations:
6463
required: true
6564

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ contact_links:
99
about: NGINX follows the Contributor Covenant Code of Conduct to ensure a safe and inclusive community
1010
- name: 💼 For commercial & enterprise users
1111
url: https://www.f5.com/products/nginx
12-
about: F5 offers a wide range of NGINX products for commercial & enterprise users
12+
about: F5 offers a wide range of NGINX products for commercial & enterprise users

.github/ISSUE_TEMPLATE/feature_request.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ body:
1414
**Note:** If you are seeking community support or have a question, please consider starting a new thread via [GitHub discussions][discussions] or the [NGINX Community forum][forum].
1515
1616
[issue search]: https://github.com/nginx/nginx-s3-gateway/issues
17-
1817
[discussions]: https://github.com/nginx/nginx-s3-gateway/discussions
1918
[forum]: https://community.nginx.org
2019

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Describe the use case and detail of the change. If this PR addresses an issue on
77
Before creating a pull request (PR), run through this checklist and mark each as complete:
88

99
- [ ] I have read the [contributing guidelines](/CONTRIBUTING.md).
10-
- [ ] I have signed the [F5 Contributor License Agreement (CLA)](https://github.com/f5/.github/blob/main/CLA/cla-markdown.md).
10+
- [ ] I have signed the [F5 Contributor License Agreement (CLA)](https://github.com/f5/f5-cla/blob/main/docs/f5_cla.md).
1111
- [ ] The PR title follows the [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/).
1212
- [ ] If applicable, I have added tests that prove my fix is effective or that my feature works.
1313
- [ ] If applicable, I have checked that any relevant tests pass after adding my changes.

.github/workflows/f5-cla.yml renamed to .github/workflows/f5_cla.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
name: F5 CLA
33
on:
44
issue_comment:
5-
types: [ created ]
5+
types: [created]
66
pull_request_target:
7-
types: [ opened, closed, synchronize ]
7+
types: [opened, closed, synchronize]
88
permissions: read-all
99
jobs:
1010
f5-cla:

.github/workflows/ossf-scorecard.yml renamed to .github/workflows/ossf_scorecard.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,19 @@ on:
88
schedule:
99
- cron: "0 0 * * 1"
1010
push:
11-
branches: [main, master]
11+
branches: [main]
1212
workflow_dispatch:
1313
# Declare default permissions as read only.
1414
permissions: read-all
1515
jobs:
1616
analysis:
1717
name: Scorecard analysis
1818
runs-on: ubuntu-24.04
19-
# Delete the conditional below if you are using the OSSF Scorecard on a private repository.
20-
if: ${{ github.event.repository.private == false }}
2119
permissions:
2220
# Needed if using Code Scanning alerts.
2321
security-events: write
2422
# Needed for GitHub OIDC token if publish_results is true.
2523
id-token: write
26-
# Uncomment the permissions below if you are using the OSSF Scorecard on a private repository.
27-
# contents: read
28-
# actions: read
29-
# issues: read # To allow GraphQL ListCommits to work
30-
# pull-requests: read # To allow GraphQL ListCommits to work
31-
# checks: read # To detect SAST tools
3224
steps:
3325
- name: Check out the codebase
3426
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -40,10 +32,6 @@ jobs:
4032
with:
4133
results_file: results.sarif
4234
results_format: sarif
43-
# (Optional) fine-grained personal access token. Uncomment the `repo_token` line below if you want to enable the Branch-Protection or Webhooks check on a *private* repository.
44-
# To create the PAT, follow the steps in https://github.com/ossf/scorecard-action#authentication-with-fine-grained-pat-optional.
45-
# repo_token: ${{ secrets.SCORECARD_TOKEN }}
46-
4735
# Publish the results for public repositories to enable scorecard badges. For more details, see https://github.com/ossf/scorecard-action#publishing-results.
4836
# For private repositories, `publish_results` will automatically be set to `false`, regardless of the value entered here.
4937
publish_results: true

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/nginxinc/nginx-s3-gateway/badge)](https://securityscorecards.dev/viewer/?uri=github.com/nginxinc/nginx-s3-gateway)
33
[![Project Status: Active – The project has reached a stable, usable state and is being actively developed.](https://www.repostatus.org/badges/latest/active.svg)](https://www.repostatus.org/#active)
44
[![Community Support](https://badgen.net/badge/support/community/cyan?icon=awesome)](/SUPPORT.md)
5+
[![Community Forum](https://img.shields.io/badge/community-forum-009639?logo=discourse&link=https%3A%2F%2Fcommunity.nginx.org)](https://community.nginx.org)
6+
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/license/apache-2-0)
57
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](/CODE_OF_CONDUCT.md)
68

79
# NGINX S3 Gateway
@@ -103,4 +105,4 @@ Please see the [contributing guide](/CONTRIBUTING.md) for guidelines on how to b
103105

104106
[Apache License, Version 2.0](/LICENSE)
105107

106-
© [F5, Inc.](https://www.f5.com/) 2020 - 2024
108+
© [F5, Inc.](https://www.f5.com/) 2020 - 2025

SUPPORT.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ at <https://mailman.nginx.org/mailman3/lists/>!
3636
Please see the [contributing guide](/CONTRIBUTING.md) or the [Getting Started](/README.md#getting-started) guide, for
3737
guidelines on how to best contribute to this project.
3838

39-
<!-- ## Commercial Support
40-
41-
Commercial support for this project may be available. Please get in touch with [NGINX sales](https://www.f5.com/products/get-f5/) or check your contract details for more information! -->
42-
4339
## Community Support
4440

4541
This project does **not** offer commercial support. Community support is offered on a best effort basis through either

0 commit comments

Comments
 (0)