chore: logging improvements

Author: dareste

pkg/data_collector/data_collector.go

@@ -158,12 +158,20 @@ func (c *DataCollector) PodExecutor(namespace string, pod string, command []stri
 			TTY:     true,
 		}, scheme.ParameterCodec)
 
-	exec, _ := remotecommand.NewSPDYExecutor(c.K8sRestConfig, "POST", req.URL())
+	exec, err := remotecommand.NewSPDYExecutor(c.K8sRestConfig, "POST", req.URL())
+	if err != nil {
+		return nil, err
+	}
 	var stdout, stderr bytes.Buffer
-	err := exec.StreamWithContext(ctx, remotecommand.StreamOptions{
+	err = exec.StreamWithContext(ctx, remotecommand.StreamOptions{
 		Stdin:  nil,
 		Stdout: &stdout,
 		Stderr: &stderr,
 	})
-	return stdout.Bytes(), err
+	if stdout.Len() > 0 || stderr.Len() > 0 {
+		response := append(stdout.Bytes(), stderr.Bytes()...)
+		return response, nil
+	} else {
+		return nil, err
+	}
 }

pkg/jobs/job.go

@@ -41,7 +41,6 @@ func (j Job) Collect(dc *data_collector.DataCollector) error {
 			return jobResults.Error
 		}
 
-		dc.Logger.Printf("\tJob %s completed successfully\n", j.Name)
 		for fileName, fileValue := range jobResults.Files {
 			err := os.MkdirAll(path.Dir(fileName), os.ModePerm)
 			if err != nil {
@@ -53,7 +52,9 @@ func (j Job) Collect(dc *data_collector.DataCollector) error {
 				return err
 			}
 			_ = file.Close()
+			dc.Logger.Printf("\tJob %s wrote file %s\n", j.Name, fileName)
 		}
+		dc.Logger.Printf("\tJob %s completed successfully\n---\n", j.Name)
 		return nil
 	}
 }