Skip to content

Commit 437ea4a

Browse files
committed
fix: include container in the pod log retrieval call
1 parent 879672b commit 437ea4a

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

internal/jobs/job_list.go

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"bytes"
55
"context"
66
"encoding/json"
7+
"fmt"
78
"github.com/nginxinc/kubectl-kic-supportpkg/internal/data_collector"
89
"io"
910
corev1 "k8s.io/api/core/v1"
@@ -34,18 +35,20 @@ func JobList() []Job {
3435
Execute: func(dc *data_collector.DataCollector, ctx context.Context) map[string][]byte {
3536
results := make(map[string][]byte)
3637
for _, namespace := range dc.Namespaces {
37-
pods, _ := dc.K8sCoreClientSet.CoreV1().Pods(namespace).List(ctx, metav1.ListOptions{FieldSelector: "name"})
38+
pods, _ := dc.K8sCoreClientSet.CoreV1().Pods(namespace).List(ctx, metav1.ListOptions{})
3839
for _, pod := range pods.Items {
39-
logFileName := path.Join(dc.BaseDir, namespace, "logs", pod.Name+".txt")
40-
bufferedLogs := dc.K8sCoreClientSet.CoreV1().Pods(namespace).GetLogs(pod.Name, &corev1.PodLogOptions{})
41-
podLogs, err := bufferedLogs.Stream(context.TODO())
42-
if err != nil {
43-
log.Fatal("error in opening stream")
40+
for _, container := range pod.Spec.Containers {
41+
logFileName := path.Join(dc.BaseDir, namespace, "logs", fmt.Sprintf("%s__%s.txt", pod.Name, container.Name))
42+
bufferedLogs := dc.K8sCoreClientSet.CoreV1().Pods(namespace).GetLogs(pod.Name, &corev1.PodLogOptions{Container: container.Name})
43+
podLogs, err := bufferedLogs.Stream(context.TODO())
44+
if err != nil {
45+
log.Fatal("error in opening stream")
46+
}
47+
buf := new(bytes.Buffer)
48+
_, _ = io.Copy(buf, podLogs)
49+
podLogs.Close()
50+
results[logFileName] = buf.Bytes()
4451
}
45-
buf := new(bytes.Buffer)
46-
_, _ = io.Copy(buf, podLogs)
47-
podLogs.Close()
48-
results[logFileName] = buf.Bytes()
4952
}
5053
}
5154
return results
@@ -190,9 +193,14 @@ func JobList() []Job {
190193
Execute: func(dc *data_collector.DataCollector, ctx context.Context) map[string][]byte {
191194
jobResults := make(map[string][]byte)
192195
settings := dc.K8sHelmClientSet.GetSettings()
196+
//release, _ := dc.K8sHelmClientSet.GetRelease("nginx-ingress-0")
197+
//fmt.Printf(release.Name)
193198
jsonSettings, _ := json.MarshalIndent(settings, "", " ")
194199
jobResults[path.Join(dc.BaseDir, "helm", "settings.json")] = jsonSettings
195-
releases, _ := dc.K8sHelmClientSet.ListDeployedReleases()
200+
releases, err := dc.K8sHelmClientSet.ListDeployedReleases()
201+
if err != nil {
202+
fmt.Printf("Error: %s", err)
203+
}
196204
jsonReleases, _ := json.MarshalIndent(releases, "", " ")
197205
jobResults[path.Join(dc.BaseDir, "helm", "releases.json")] = jsonReleases
198206
return jobResults

0 commit comments

Comments
 (0)