Review: Address comments

* Add test for failing to get pod-list from k8s
* Replace deprecated NewSimpleClientset() with NewClientset()

Author: mrajagopal

pkg/jobs/common_job_list_test.go

@@ -1,13 +1,22 @@
 package jobs
 
 import (
+	"bytes"
 	"context"
+	"fmt"
+	"log"
 	"path/filepath"
 	"strings"
 	"testing"
 	"time"
 
+	"github.com/nginxinc/nginx-k8s-supportpkg/pkg/data_collector"
 	"github.com/nginxinc/nginx-k8s-supportpkg/pkg/mock"
+	"github.com/stretchr/testify/assert"
+	"go.uber.org/mock/gomock"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/client-go/kubernetes/fake"
+	k8stesting "k8s.io/client-go/testing" // Add this line
 )
 
 func TestCommonJobList_SelectedJobsProduceFiles(t *testing.T) {
@@ -81,3 +90,55 @@ func TestCommonJobList_PodListJSONKeyPresence(t *testing.T) {
 		}
 	}
 }
+
+func TestCommonJobList_PodListError(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	// Create mock clients
+	mockClient := fake.NewSimpleClientset()
+
+	// Add a reactor that returns an error for pod list operations
+	mockClient.PrependReactor("list", "pods", func(action k8stesting.Action) (handled bool, ret runtime.Object, err error) {
+		return true, nil, fmt.Errorf("mock API error: pods not available")
+	})
+
+	// Setup data collector with error-prone client
+	tmpDir := t.TempDir()
+	var logOutput bytes.Buffer
+
+	dc := &data_collector.DataCollector{
+		BaseDir:          tmpDir,
+		Namespaces:       []string{"default", "test-namespace"},
+		Logger:           log.New(&logOutput, "", 0),
+		K8sCoreClientSet: mockClient,
+	}
+
+	// Execute the pod-list job
+	var podJob []Job
+	jobs := CommonJobList()
+	for _, job := range jobs {
+		if job.Name == "pod-list" || job.Name == "collect-pods-logs" {
+			podJob = append(podJob, job)
+		}
+	}
+	// podJob := jobs[0] // First job is pod-list
+
+	ctx := context.Background()
+	ch := make(chan JobResult, 1)
+	for _, job := range podJob {
+		job.Execute(dc, ctx, ch)
+
+		result := <-ch
+
+		// Assertions
+		logContent := logOutput.String()
+		assert.Contains(t, logContent, "Could not retrieve pod list for namespace default")
+		assert.Contains(t, logContent, "Could not retrieve pod list for namespace test-namespace")
+		assert.Contains(t, logContent, "mock API error: pods not available")
+
+		// No files should be created since API calls failed
+		assert.Empty(t, result.Files)
+		assert.Nil(t, result.Error) // The job itself doesn't fail, just logs errors
+	}
+}

pkg/mock/mock_data_collector.go

@@ -68,7 +68,7 @@ func SetupMockDataCollector(t *testing.T) *data_collector.DataCollector {
 		t.Fatalf("Failed to load test objects: %v", err)
 	}
 
-	client := fake.NewSimpleClientset(objs...)
+	client := fake.NewClientset(objs...)
 
 	// Mock rest.Config
 	restConfig := &rest.Config{