Issue #4: Fix - validate namespaces input by user via cmdline

* Convert allNamespacesExist() into a member function of the DataCollector object for succinctness

Author: mrajagopal

cmd/nic-supportpkg.go

@@ -1,12 +1,10 @@
 package cmd
 
 import (
-	"context"
 	"fmt"
 	"github.com/nginxinc/nginx-k8s-supportpkg/pkg/data_collector"
 	"github.com/nginxinc/nginx-k8s-supportpkg/pkg/jobs"
 	"github.com/spf13/cobra"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"os"
 )
 
@@ -26,8 +24,7 @@ func Execute() {
 				os.Exit(1)
 			}
 
-			if allNamespacesExist(collector) == true {
-
+			if collector.AllNamespacesExist() == true {
 				for _, job := range jobs.JobList() {
 					fmt.Printf("Running job %s...", job.Name)
 					err = job.Collect(collector)
@@ -63,18 +60,3 @@ func Execute() {
 		os.Exit(1)
 	}
 }
-
-func allNamespacesExist(dc *data_collector.DataCollector) bool {
-
-	var allExist bool = true
-	for _, namespace := range dc.Namespaces {
-		_, err := dc.K8sCoreClientSet.CoreV1().Namespaces().Get(context.TODO(), namespace, metav1.GetOptions{})
-		if err != nil {
-			dc.Logger.Printf("\t%s: %v\n", namespace, err)
-			fmt.Printf("\t%s: %v\n", namespace, err)
-			allExist = false
-		}
-	}
-
-	return allExist
-}

pkg/data_collector/data_collector.go

@@ -10,6 +10,7 @@ import (
 	"io"
 	corev1 "k8s.io/api/core/v1"
 	crdClient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/kubernetes/scheme"
 	"k8s.io/client-go/rest"
@@ -175,3 +176,17 @@ func (c *DataCollector) PodExecutor(namespace string, pod string, command []stri
 		return nil, err
 	}
 }
+
+func (c *DataCollector) AllNamespacesExist() bool {
+	var allExist bool = true
+	for _, namespace := range c.Namespaces {
+		_, err := c.K8sCoreClientSet.CoreV1().Namespaces().Get(context.TODO(), namespace, metav1.GetOptions{})
+		if err != nil {
+			c.Logger.Printf("\t%s: %v\n", namespace, err)
+			fmt.Printf("\t%s: %v\n", namespace, err)
+			allExist = false
+		}
+	}
+
+	return allExist
+}