Skip to content

Basic integration test for NIC #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 10, 2025
Merged

Basic integration test for NIC #199

merged 6 commits into from
Sep 10, 2025

Conversation

dareste
Copy link
Collaborator

@dareste dareste commented Sep 9, 2025

Proposed changes

These changes create an integration test that runs the following steps in a CI pipeline:

  • Install a lightweight k8s (kind).
  • Install the latest NIC via Helm.
  • Compile the supportpkg binay and run it.
  • Analyze the generated tarball.
  • Confirm the tarball contains expected files.

@dareste dareste requested a review from mrajagopal September 9, 2025 16:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 9, 2025
View reviewed changes
mrajagopal
mrajagopal approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@mrajagopal mrajagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
We could do separate ones for NIM, NGF and NGX (if we have a convenient helm deployment)

@dareste dareste merged commit 8eedd67 into main Sep 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrajagopal mrajagopal mrajagopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dareste @mrajagopal