Align SyntaxError reporting with other JS engines.

Previously, "in <file>:<file>" was a part of the error message. Now
the file name is reported as "stack" property.

This fixes #1005 issue on Github.

Author: xeioex

src/njs_error.c

@@ -217,6 +217,34 @@ njs_error_stack_attach(njs_vm_t *vm, njs_value_t value, njs_uint_t skip)
 }
 
 
+void
+njs_error_stack_set(njs_vm_t *vm, njs_value_t *value, njs_str_t *file,
+    njs_int_t line)
+{
+    njs_chb_t    chain;
+    njs_value_t  *stackval;
+
+    if (njs_slow_path(!vm->options.backtrace
+                      || !njs_is_error(value))
+                      || njs_object(value)->stack_attached)
+    {
+        return;
+    }
+
+    NJS_CHB_MP_INIT(&chain, vm->mem_pool);
+
+    njs_chb_sprintf(&chain, njs_length("    at :\n") + NJS_INT_T_LEN
+                            + file->length,
+                    "    at %V:%uD\n", file, line);
+
+    stackval = njs_object_value(value);
+
+    (void) njs_string_create_chb(vm, stackval, &chain);
+
+    njs_chb_destroy(&chain);
+}
+
+
 njs_int_t
 njs_error_stack(njs_vm_t *vm, njs_value_t *value, njs_value_t *stack)
 {

src/njs_error.h

@@ -44,6 +44,8 @@ njs_int_t njs_error_to_string(njs_vm_t *vm, njs_value_t *retval,
     const njs_value_t *error);
 njs_int_t njs_error_stack(njs_vm_t *vm, njs_value_t *value, njs_value_t *stack);
 void njs_error_stack_attach(njs_vm_t *vm, njs_value_t value, njs_uint_t skip);
+void njs_error_stack_set(njs_vm_t *vm, njs_value_t *value, njs_str_t *file,
+    njs_int_t line);
 
 
 extern const njs_object_type_init_t  njs_error_type_init;

src/njs_parser.c

@@ -9205,11 +9205,9 @@ static void
 njs_parser_error(njs_vm_t *vm, njs_object_type_t type, njs_str_t *file,
     uint32_t line, const char *fmt, va_list args)
 {
-    size_t       width;
     u_char       msg[NJS_MAX_ERROR_STR];
     u_char       *p, *end;
-    njs_int_t    ret;
-    njs_value_t  value, error;
+    njs_value_t  error;
 
     if (njs_slow_path(vm->top_frame == NULL)) {
         njs_vm_runtime_init(vm);
@@ -9220,29 +9218,10 @@ njs_parser_error(njs_vm_t *vm, njs_object_type_t type, njs_str_t *file,
 
     p = njs_vsprintf(p, end, fmt, args);
 
-    width = njs_length(" in ") + file->length + NJS_INT_T_LEN;
-
-    if (p > end - width) {
-        p = end - width;
-    }
-
-    if (file->length != 0 && !vm->options.quiet) {
-        p = njs_sprintf(p, end, " in %V:%uD", file, line);
-
-    } else {
-        p = njs_sprintf(p, end, " in %uD", line);
-    }
-
     njs_error_new(vm, &error, njs_vm_proto(vm, type), msg, p - msg);
 
-    njs_set_number(&value, line);
-    njs_value_property_set(vm, &error, NJS_ATOM_STRING_lineNumber, &value);
-
-    if (file->length != 0) {
-        ret = njs_string_create(vm, &value, file->start, file->length);
-        if (ret == NJS_OK) {
-            njs_value_property_set(vm, &error, NJS_ATOM_STRING_fileName, &value);
-        }
+    if (!vm->options.quiet && file->length != 0) {
+        njs_error_stack_set(vm, &error, file, line);
     }
 
     njs_vm_throw(vm, &error);