Skip to content

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Feb 14, 2025

Starting with Fedora 42 /usr/sbin is no more used, so default value is no more suitable

So %{_sbindir} is defined as /usr/bin

@thresheek
Copy link
Member

Hello! Thank you for your contribution!

LGTM except for a few minor nits:

  • commit message should be something like:
    Packaging: Ensure sbindir is properly set on newer Fedora (42+)

  • probably squash into one commit?

  • shall we use a %{__sed} macro instead of a direct invocation? I'm not really following the contemporary stance on using macros vs directly calling executables in the specs, but at least it would be inline with pretty much all the other calls in the spec file.

@remicollet
Copy link
Contributor Author

shall we use a %{__sed}

No.

@remicollet
Copy link
Contributor Author

Notice: this is only the mandatory change required to build F42 package

BTW current spec file is outdated

Especially for

  • systemd
  • sysusers

Switch to systemd packaging work for all Fedora and EL >= 8
Switch to sysusers packaging work for all Fedora and EL >= 8, and is mandatory for F42

Ex recent change done for my repo
https://git.remirepo.net/cgit/rpms/unit.git/commit/?id=22a5372cf24b0d2e26aa74948b2e797ac880dfc3

@thresheek thresheek self-assigned this Feb 18, 2025
@ac000
Copy link
Member

ac000 commented Aug 14, 2025

@thresheek

Unless you have any objections, I'm going to go ahead and merge this...

@thresheek
Copy link
Member

Yeah I think it's fine.

@thresheek thresheek self-requested a review August 14, 2025 20:10
@ac000 ac000 merged commit 29dc400 into nginx:master Aug 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants