Use more specific handler names (#27)

Author: alessfg

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.3.1 (Unreleased)
+
+BUG FIXES:
+
+*   Rename handlers to use more specific role related naming and prevent namespace collision issues.
+
 ## 0.3.0 (September 21, 2020)
 
 DEPRECATION WARNING:

handlers/main.yml

@@ -1,27 +1,27 @@
 ---
-- name: (Handler) Systemd daemon-reload
+- name: (Handler - NGINX App Protect) Systemd daemon-reload
   systemd:
     daemon_reload: true
 
-- name: (Handler) Check NGINX
+- name: (Handler - NGINX App Protect) Check NGINX
   command: nginx -t
   register: config
   ignore_errors: true
-  listen: (Handler) Run NGINX
+  listen: (Handler - NGINX App Protect) Run NGINX
 
-- name: (Handler) Print NGINX error if syntax check fails
+- name: (Handler - NGINX App Protect) Print NGINX error if syntax check fails
   debug:
     var: config.stderr_lines
   failed_when: config.rc != 0
   when: config.rc != 0
-  listen: (Handler) Run NGINX
+  listen: (Handler - NGINX App Protect) Run NGINX
 
-- name: (Handler) Start/Reload NGINX
+- name: (Handler - NGINX App Protect) Start/reload NGINX
   service:
     name: nginx
     state: reloaded
     enabled: true
   when:
     - nginx_app_protect_start | bool
     - not ansible_check_mode | bool
-  listen: (Handler) Run NGINX
+  listen: (Handler - NGINX App Protect) Run NGINX

tasks/config/configure-app-protect.yml

@@ -15,6 +15,7 @@
     mode: 0644
     backup: true
   when: nginx_app_protect_security_policy_template_enable | bool
+  notify: (Handler - NGINX App Protect) Run NGINX
 
 - name: Dynamically generate NGINX App Protect log policy file
   template:
@@ -23,6 +24,7 @@
     mode: 0644
     backup: true
   when: nginx_app_protect_log_policy_template_enable | bool
+  notify: (Handler - NGINX App Protect) Run NGINX
 
 - name: (DEPRECATED) Backup existing nginx.conf
   copy:
@@ -41,6 +43,7 @@
   when:
     - nginx_app_protect_conf_template_enable | bool
     - nginx_app_protect_state != "absent"
+  notify: (Handler - NGINX App Protect) Run NGINX
 
 - name: (DEPRECATED) Remove NGINX App Protect
   block:
@@ -55,12 +58,5 @@
         path: /etc/nginx/nginx.conf
         regexp: '^([ \t]*app_protect_)'
         replace: '# \1'
+      notify: (Handler - NGINX App Protect) Run NGINX
   when: nginx_app_protect_state == "absent"
-
-- name: Reload NGINX
-  debug:
-    msg: Trigger nginx reload if needed
-  notify: (Handler) Run NGINX
-  when: nginx_app_protect_security_policy_template_enable | bool
-        or nginx_app_protect_log_policy_template_enable | bool
-        or nginx_app_protect_conf_template_enable | bool

tasks/install/install-app-protect.yml

@@ -22,21 +22,21 @@
   package:
     name: "app-protect{{ nginx_app_protect_version | default('') }}"
     state: "{{ nginx_app_protect_state }}"
-  notify: (Handler) Run NGINX
+  notify: (Handler - NGINX App Protect) Run NGINX
 
 - name: Install latest NGINX App Protect signatures
   package:
     name: app-protect-attack-signatures
     state: "{{ nginx_app_protect_state }}"
   when: nginx_app_protect_install_signatures | bool
-  notify: (Handler) Run NGINX
+  notify: (Handler - NGINX App Protect) Run NGINX
 
 - name: Install latest NGINX App Protect threat campaigns
   package:
     name: app-protect-threat-campaigns
     state: "{{ nginx_app_protect_state }}"
   when: nginx_app_protect_install_threat_campaigns | bool
-  notify: (Handler) Run NGINX
+  notify: (Handler - NGINX App Protect) Run NGINX
 
 - name: Modify NGINX Plus service
   block:
@@ -53,5 +53,5 @@
         owner: root
         group: root
         mode: 0644
-      notify: (Handler) Systemd daemon-reload
+      notify: (Handler - NGINX App Protect) Systemd daemon-reload
   when: nginx_app_protect_timeout is defined