Merge pull request #107 from ryepup/limit-req-tests

test: expand limit_req_zone coverage

Author: ryepup

analyze_test.go

@@ -2605,28 +2605,50 @@ func TestAnalyze_directiveSources_defaultBehavior(t *testing.T) {
 func TestAnalyze_limit_req_zone(t *testing.T) {
 	t.Parallel()
 	testcases := map[string]struct {
-		stmt    *Directive
-		ctx     blockCtx
+		args    []string
+		sources []MatchFunc
 		wantErr bool
 	}{
-		"limit_req_zone ok http": {
-			&Directive{
-				Directive: "limit_req_zone",
-				Args:      []string{"$binary_remote_addr", "zone=one:10m", "rate=1r/s", "sync"},
-				Line:      5,
-			},
-			blockCtx{"http"},
-			false,
+		"limit_req_zone_4_args_nplus_latest": {
+			args:    []string{"$binary_remote_addr", "zone=one:10m", "rate=1r/s", "sync"},
+			sources: []MatchFunc{NgxPlusLatestDirectivesMatchFn},
+			wantErr: false,
+		},
+		"limit_req_zone_3_args_nplus_latest": {
+			args:    []string{"$binary_remote_addr", "zone=one:10m", "rate=1r/s"},
+			sources: []MatchFunc{NgxPlusLatestDirectivesMatchFn},
+			wantErr: false,
+		},
+		"limit_req_zone_4_args_oss_latest": {
+			args:    []string{"$binary_remote_addr", "zone=one:10m", "rate=1r/s", "sync"},
+			sources: []MatchFunc{OssLatestDirectivesMatchFn},
+			wantErr: true,
+		},
+		"limit_req_zone_3_args_oss_latest": {
+			args:    []string{"$binary_remote_addr", "zone=one:10m", "rate=1r/s"},
+			sources: []MatchFunc{OssLatestDirectivesMatchFn},
+			wantErr: false,
+		},
+		"limit_req_zone_4_args_default_sources": {
+			args:    []string{"$binary_remote_addr", "zone=one:10m", "rate=1r/s", "sync"},
+			wantErr: false,
+		},
+		"limit_req_zone_3_args_default_sources": {
+			args:    []string{"$binary_remote_addr", "zone=one:10m", "rate=1r/s"},
+			wantErr: false,
 		},
 	}
 
 	for name, tc := range testcases {
 		tc := tc
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
-			err := analyze("nginx.conf", tc.stmt, ";", tc.ctx, &ParseOptions{
-				DirectiveSources: []MatchFunc{NgxPlusLatestDirectivesMatchFn, AppProtectWAFv4DirectivesMatchFn},
-			})
+			stmt := &Directive{
+				Directive: "limit_req_zone",
+				Args:      tc.args,
+				Line:      5,
+			}
+			err := analyze("nginx.conf", stmt, ";", blockCtx{"http"}, &ParseOptions{DirectiveSources: tc.sources})
 
 			if !tc.wantErr && err != nil {
 				t.Fatal(err)