Cards: Removed showAsSingleRow option

Author: lamATnginx

exampleSite/content/test-product/cards/permitted.md

@@ -39,37 +39,14 @@ To support customization, there are also some params you can add to the shortcod
 * `isFullSize` (optional) - Boolean indicating whether or not the card should be full size. By default, cards are half sized.
   * Usage: `<card isFullSize="true"...>`
 
-For the `<card-section>`, there are some params you can add such as `title`, `isFeaturedSection`, and `showAsSingleRow`.
+For the `<card-section>`, there are some params you can add such as `title` and `isFeaturedSection`.
 * `title` - Title of the section.
 <br>
 * `isFeaturedSection` (optional) - Boolean indicating whether or not the section is a featured one - will discuss later down the page. By default, false.
-<br> 
-* `showAsSingleRow` (optional) - Boolean indicating whether or not the cards in the section should appear without borders + one card per row. By default, false.
 
 ### Additional Information
 While it may come immediate, you can't use a `<card>` shortcode on its own in your markdown or else the build will fail. This is because if you call a card, there is no way to structure it in a writer-friendly customizable way. 
 
-## Show as single row
-As you can see from the above example in 'General usage', it renders as a block with borders, aka a card. To change the appearance and render without the borders and move to one card per row, use the param `showAsSingleRow` in the shortcode `<card-section>`. The usage as seen below:
-```plaintext
-  <card-section showAsSingleRow="true">
-      <card title="SOME_TITLE">SOME CONTENT icon="SOME_LUCIDE_ICON">SOME CONTENT<\card>
-      ...
-      <card>...<\card>
-  </card-section>
-```
-and will render as the following:
-<div data-testid="cards-test__showAsSingleRow">
-  {{<card-section showAsSingleRow="true">}}
-    {{<card title="SOME_TITLE_1">}}
-      SOME CONTENT 1
-    {{</card >}}
-    {{<card title="SOME_TITLE_2">}}
-      SOME CONTENT 2
-    {{</card >}}
-  {{</card-section>}}
-</div>
-
 ## Featured Section
 Denoted by the param `isFeaturedSection` in the shortcode `<card-section>`, this block of cards can contain only up to three cards. The usage as seen below:
 ```plaintext 

layouts/shortcodes/card-section.html

@@ -1,30 +1,20 @@
 {{ $title := .Get "title" }}
 {{ $isFeaturedSectionParam := .Get "isFeaturedSection" | default "false" }}
-{{ $showAsSingleRowParam := .Get "showAsSingleRow" | default "false"}}
 
-{{- /* Validate the parameter strictly */ -}}
-{{- if not (in (slice "true" "false") $showAsSingleRowParam) -}}
-  {{- warnf "The '<card-section>' Shortcode parameter 'showAsSingleRow' must be 'true' or 'false', but got: '%s'. This will now default to 'false'" $showAsSingleRowParam -}}
-{{- end -}}
-{{- $showAsSingleRow := cond (eq $showAsSingleRowParam "true") "true" "false" -}}
-{{- $current := .Page.Scratch.Get "showAsSingleRow" | default (dict) -}}
-{{- $newShowAsSingleRow := dict ($title | default "main") ($showAsSingleRow) -}}
-{{- .Page.Scratch.Set "showAsSingleRow" (merge $current ($newShowAsSingleRow)) -}}
 {{- /* Limit the cards if it is a featured section */ -}}
 {{- if not (in (slice "true" "false") $isFeaturedSectionParam) -}}
   {{- warnf "The '<card-section>' Shortcode parameter 'isFeaturedSection' must be 'true' or 'false', but got: '%s'. This will now default to 'false'" $isFeaturedSectionParam -}}
 {{- end -}}
 {{- $isFeaturedSection := cond (eq $isFeaturedSectionParam "true") "true" "false" -}}
-{{- $class := "card-grid" -}}
+{{- $class := "card-section-content card-grid" -}}
 
 {{- /* Get number of cards */ -}}
 {{ $cardCount := len (findRE "<div\\s+class=\"card\"[\\s\\S]*?>" .Inner) }}
-
 <div class="card-section{{if eq $isFeaturedSection "true"}} featured-section{{ end }}" data-testid="{{if eq $isFeaturedSection "true"}}card-section__featured-section{{else}}card-section{{ end }}">
   {{- if $title -}}
     <strong class="card-section-title">{{- $title -}}</strong>
-    <div class="card-section-content{{ if eq $showAsSingleRow "false" }} {{ $class }}{{ end }}" data-testid="{{ if eq $showAsSingleRow "false" }}card-section-content__card-grid{{else}}card-section-content{{ end }}">{{ .Inner }}</div>    
+    <div class="{{ $class }}" data-testid="card-section-content__card-grid">{{ .Inner }}</div>    
   {{ else }}
-    <div class="card-section-content{{ if eq $showAsSingleRow "false" }} {{ $class }}{{ end }}" data-testid="{{ if eq $showAsSingleRow "false" }}card-section-content__card-grid{{else}}card-section-content{{ end }}">{{ .Inner }}</div>    
+    <div class="{{ $class }}" data-testid="card-section-content__card-grid">{{ .Inner }}</div>    
   {{ end }}
 </div>

tests/src/cards.spec.js

@@ -11,21 +11,6 @@ test.describe('Testing for cards shortcode', () => {
     const showAsCardCode = await section.locator(
       'data-testid=card-section-content'
     );
-    const basicCode = await section.locator(
-      'data-testid=card-section-content__card-grid'
-    );
-
-    expect(await showAsCardCode.count()).toBe(0);
-    expect(await basicCode.count()).toBeTruthy();
-  });
-
-  test('should test showAsSingleRow section', async ({ page }) => {
-    const section = await page.locator(
-      'data-testid=cards-test__showAsSingleRow'
-    );
-    const showAsCardCode = await section.locator(
-      'data-testid=card-section-content__card-grid'
-    );
 
     expect(await showAsCardCode.count()).toBe(0);
   });