Skip to content

Added color to callout varieties #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 3, 2025
Merged

Added color to callout varieties #212

merged 4 commits into from
Apr 3, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Apr 2, 2025 •
edited
Loading

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/428

Before:
Screenshot 2025-04-02 at 10 05 51 AM

After:
Screenshot 2025-04-02 at 10 06 05 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the enhancement New feature or request label Apr 2, 2025
@lamATnginx lamATnginx self-assigned this Apr 2, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner April 2, 2025 16:54
@lamATnginx lamATnginx marked this pull request as draft April 2, 2025 16:55
@lamATnginx lamATnginx marked this pull request as ready for review April 2, 2025 16:57
@lamATnginx lamATnginx force-pushed the feat/callout-colors branch from e61656e to c8a90ff Compare April 2, 2025 17:04
lamATnginx
lamATnginx commented Apr 2, 2025
View reviewed changes
@danielledeleo
Copy link
Contributor

Screenshot 2025-04-02 at 1 19 23 PM

If there's a <strong> in the body of the callout you end up with another heading. Let's add a class to avoid this.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

❌ Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@danielledeleo
Copy link
Contributor

/approve-snapshots

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

Updating snapshots. Click here to see the status.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

Please download the artifacts here and commit your updated screenshots.

@nginx-jack nginx-jack merged commit 398ac25 into main Apr 3, 2025
7 checks passed
@nginx-jack nginx-jack deleted the feat/callout-colors branch July 31, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nginx-jack nginx-jack nginx-jack approved these changes

Assignees

@lamATnginx lamATnginx

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lamATnginx @danielledeleo @nginx-jack