Killing Oldframe #276
Open
Killing Oldframe #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Playwright visual snapshot differences were detected.View the Playwright report |
✅ Deploy Preview will be available once build job completes!
|
|
Tab groups not working as expected - taking a look. |
|
F5 Sites button not working as expected as well. Related to the tabs group. Edit: Resolved |
❌ One or more of the commit messages in this PR do not match the nginx-hugo-theme git guidelines, please check the CI job for more details on which commits were flagged and why.Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR. |
lamATnginx
force-pushed
the
mainframe
branch
3 times, most recently
from
0f6ac99 to
6de8fe8
Compare
TasoOneAsia
requested changes
Jun 17, 2025
* Card: Handle case of no inner for cards * Card: Updated test product landing page
* Redocly: Add support for content on redocly pages * Redocly: Fix redoc sidebar hiding under the header * Redocly: Fix mobile sidebar alignment --------- Co-authored-by: Lam Nguyen <[email protected]>
Fix usages of color-foreground. It's oklch based, but had usages directly on color without oklch wrapper. Widen sidebar to 24rem
* Cards: Removed card-layout shortcode + replaced showAsCards with new param name * Cards: Removed showAsSingleRow option
* Grid: Changed min width of parent grid to be smaller * Grid: Removed overflow on callouts + codeblocks + set min width to zero * Grid: Fixed sidebar width * Grid: Added breadcrumb line overflow fully
* Card: Add even spacing * Card: Add variable for spacing * Card: Added displacement to gap to accord for grip gap * Card: Add hover effect to all cards
* Card: Fix icon size + add alignment * Card: Fix issue with icon shrinking
* Coveo: Fix clipping on sidebar + touch up colors * Coveo: Refactor variables * Coveo: Added search on homepage + fixed mobile renderings * Coveo: Make font-size consistent on searchbar * Cards: Fixed styling on search
* Breadcrumbs: Use full content width for breadcrumbs * Linting: Add lint ignores for coveo and qualtrics --------- Co-authored-by: Jack Hickey <[email protected]>
* Header: Mainframe header redesign Restyle coveo search box Restyle F5 Sites button Move search box to left side Move sidebar toggle to main header Move product selector to sidebar * Header: Hide sidebar controls on pages without a sidebar Applies to 404, search, and homepage * Header: Center header logo horizontally regardless of flow * Sidebar: Move search to top of mobile view, remove selector * Header: Fix sidebar action icon mismatch on mobile * ProductSelector: New product selector * ProductSelector: Show selected product * ProductSelector: Show selected product * Header: Adjust product selector styling * Sidebar: Adjust Coveo styling to better match product selector Applies to mobile * Sidebar: Position collapse button within sidebar on mobile --------- Co-authored-by: Michael McKeen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Lots of removing
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)