From f3dfa1af4d42b0696ada292c29bd6c1c640f1fdf Mon Sep 17 00:00:00 2001 From: Lam Nguyen Date: Wed, 9 Jul 2025 11:54:45 -0700 Subject: [PATCH 1/3] Icon: Refactored to icon shortcode instead of fe + updated old icon code --- .../content/test-product/feather/_index.md | 8 -------- .../content/test-product/feather/permitted.md | 17 ----------------- .../content/test-product/lucide/permitted.md | 13 +++++++++---- layouts/shortcodes/fa.html | 1 - layouts/shortcodes/icon-bug.html | 2 +- layouts/shortcodes/icon-feature.html | 2 +- layouts/shortcodes/icon-info.html | 2 +- layouts/shortcodes/icon-resolved.html | 2 +- layouts/shortcodes/{fe.html => icon.html} | 0 9 files changed, 13 insertions(+), 34 deletions(-) delete mode 100644 exampleSite/content/test-product/feather/_index.md delete mode 100644 exampleSite/content/test-product/feather/permitted.md delete mode 100644 layouts/shortcodes/fa.html rename layouts/shortcodes/{fe.html => icon.html} (100%) diff --git a/exampleSite/content/test-product/feather/_index.md b/exampleSite/content/test-product/feather/_index.md deleted file mode 100644 index b0e0c9f3..00000000 --- a/exampleSite/content/test-product/feather/_index.md +++ /dev/null @@ -1,8 +0,0 @@ ---- -description: Feather icon usage -title: Feather -weight: 300 -toc: true ---- - -Hello! diff --git a/exampleSite/content/test-product/feather/permitted.md b/exampleSite/content/test-product/feather/permitted.md deleted file mode 100644 index 5808079b..00000000 --- a/exampleSite/content/test-product/feather/permitted.md +++ /dev/null @@ -1,17 +0,0 @@ ---- -description: Where feather icons are allowed to be used -title: Permitted usage -weight: 100 ---- - -[Feather Icons](https://feathericons.com/) is a free icon library with a permissive license (MIT). We use it for our minimal icon needs in place of FontAwesome in Oldframe. - -{{}} - -[Feather link{{}}](#) - -{{}} in text. - -{{}} -This is a Warning callout. There was previously a bug with **bold text** that we should be aware of and continue to check for. This callout was invoked with the `` shortcode. It has no custom title. {{}} -{{}} \ No newline at end of file diff --git a/exampleSite/content/test-product/lucide/permitted.md b/exampleSite/content/test-product/lucide/permitted.md index a8fbedbd..ccaef889 100644 --- a/exampleSite/content/test-product/lucide/permitted.md +++ b/exampleSite/content/test-product/lucide/permitted.md @@ -6,11 +6,16 @@ weight: 100 [Lucide Icons](https://lucide.dev/) is a free icon library with a permissive license (MIT). We use it for our minimal icon needs in place of FontAwesome in Oldframe. -{{}} +{{}} -[Lucide link{{}}](#) +[Lucide link{{}}](#) -{{}} in text. +{{}} in text. + +{{}} +{{}} +{{}} +{{}} Here are some icons that are using font-awesome but should be backwards compatible: @@ -54,5 +59,5 @@ Here are some icons that are using font-awesome but should be backwards compatib {{}} -This is a Warning callout. There was previously a bug with **bold text** that we should be aware of and continue to check for. This callout was invoked with the `` shortcode. It has no custom title. {{}} +This is a Warning callout. There was previously a bug with **bold text** that we should be aware of and continue to check for. This callout was invoked with the `` shortcode. It has no custom title. {{}} {{}} \ No newline at end of file diff --git a/layouts/shortcodes/fa.html b/layouts/shortcodes/fa.html deleted file mode 100644 index 69734dc3..00000000 --- a/layouts/shortcodes/fa.html +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/layouts/shortcodes/icon-bug.html b/layouts/shortcodes/icon-bug.html index bd9d8b17..dbcebc90 100644 --- a/layouts/shortcodes/icon-bug.html +++ b/layouts/shortcodes/icon-bug.html @@ -1 +1 @@ - \ No newline at end of file +{{ partial "lucide" (dict "context" . "icon" "bug" "style" "color:#E4002B") }} \ No newline at end of file diff --git a/layouts/shortcodes/icon-feature.html b/layouts/shortcodes/icon-feature.html index 31bddbc5..e76d111a 100644 --- a/layouts/shortcodes/icon-feature.html +++ b/layouts/shortcodes/icon-feature.html @@ -1 +1 @@ - \ No newline at end of file +{{ partial "lucide" (dict "context" . "icon" "file-plus" "style" "color:#009639") }} \ No newline at end of file diff --git a/layouts/shortcodes/icon-info.html b/layouts/shortcodes/icon-info.html index b3525b83..ffde5eee 100644 --- a/layouts/shortcodes/icon-info.html +++ b/layouts/shortcodes/icon-info.html @@ -1 +1 @@ - \ No newline at end of file +{{ partial "lucide" (dict "context" . "icon" "info" "style" "color:#1d9cd3") }} \ No newline at end of file diff --git a/layouts/shortcodes/icon-resolved.html b/layouts/shortcodes/icon-resolved.html index 93145a9e..87e3b8d4 100644 --- a/layouts/shortcodes/icon-resolved.html +++ b/layouts/shortcodes/icon-resolved.html @@ -1 +1 @@ - \ No newline at end of file +{{ partial "lucide" (dict "context" . "icon" "bug-off" "style" "color:#666666") }} \ No newline at end of file diff --git a/layouts/shortcodes/fe.html b/layouts/shortcodes/icon.html similarity index 100% rename from layouts/shortcodes/fe.html rename to layouts/shortcodes/icon.html From c37dd2544e9f2630bf578fe9af788c8a968a624a Mon Sep 17 00:00:00 2001 From: Lam Nguyen Date: Wed, 9 Jul 2025 13:01:27 -0700 Subject: [PATCH 2/3] Icon: Fixed lucide partial --- layouts/partials/lucide.html | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/layouts/partials/lucide.html b/layouts/partials/lucide.html index dd89f95b..d8696dca 100644 --- a/layouts/partials/lucide.html +++ b/layouts/partials/lucide.html @@ -1,6 +1,3 @@ {{- /* Usage: */ -}} {{- /* (dict "context" . "icon" "circle") */ -}} - \ No newline at end of file + \ No newline at end of file From 55053fb1bcf9580066a877085ccddf3ec4807cf8 Mon Sep 17 00:00:00 2001 From: Lam Nguyen Date: Tue, 15 Jul 2025 09:42:40 -0700 Subject: [PATCH 3/3] Icon: Removed feather references --- layouts/partials/callout.html | 2 +- layouts/partials/feather.html | 5 ----- static/images/feather-sprite.svg | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) delete mode 100644 layouts/partials/feather.html delete mode 100644 static/images/feather-sprite.svg diff --git a/layouts/partials/callout.html b/layouts/partials/callout.html index 314137ac..7acf00d0 100644 --- a/layouts/partials/callout.html +++ b/layouts/partials/callout.html @@ -36,7 +36,7 @@
- {{ partial "feather" (dict "context" . "icon" $icon) .}} + {{ partial "lucide" (dict "context" . "icon" $icon) .}} {{ $title }}
diff --git a/layouts/partials/feather.html b/layouts/partials/feather.html deleted file mode 100644 index e04c8627..00000000 --- a/layouts/partials/feather.html +++ /dev/null @@ -1,5 +0,0 @@ -{{- /* Usage: */ -}} -{{- /* (dict "context" . "icon" "circle") */ -}} - - - \ No newline at end of file diff --git a/static/images/feather-sprite.svg b/static/images/feather-sprite.svg deleted file mode 100644 index b66f76f3..00000000 --- a/static/images/feather-sprite.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file