Skip to content

Breadcrumbs: Adjust list page handling to resolve awkward mobile spacing #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

Breadcrumbs: Adjust list page handling to resolve awkward mobile spacing #393

merged 1 commit into from
Sep 9, 2025

Conversation

TasoOneAsia
Copy link
Member

Proposed changes

  • Resolves awkward spacing for breadcrumbs on mobile landing pages
  • Removes grid template row property which was causing the weird sizing. Spacing provided by the grid-template-row property was replaced with margin.
  • Also adjusts the breadcrumb-layout element to data-grid="wide", fixing an issue where bottom borders extend half the screen on intermediate breakpoints.

Before

CleanShot 2025-09-09 at 15 16 47

After

CleanShot 2025-09-09 at 15 17 23

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@TasoOneAsia TasoOneAsia self-assigned this Sep 9, 2025
@TasoOneAsia TasoOneAsia requested a review from a team as a code owner September 9, 2025 19:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/393/

@TasoOneAsia
Breadcrumbs: Adjust list page handling
068f118 
Resolves awkward spacing for mobile
@TasoOneAsia TasoOneAsia force-pushed the fix/breadcrumb-layout-landings branch from a7fa639 to 068f118 Compare September 9, 2025 19:29
@TasoOneAsia TasoOneAsia merged commit a3fccd6 into main Sep 9, 2025
8 checks passed
@TasoOneAsia TasoOneAsia deleted the fix/breadcrumb-layout-landings branch September 9, 2025 19:35
maximusmith529 pushed a commit that referenced this pull request Sep 10, 2025
@TasoOneAsia @maximusmith529
Breadcrumbs: Adjust list page handling for mobile landing pages (#393)
df751f4 
Resolves awkward spacing between content and breadcrumbs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamATnginx lamATnginx lamATnginx approved these changes

Assignees

@TasoOneAsia TasoOneAsia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TasoOneAsia @lamATnginx