Skip to content

Conversation

@lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Nov 5, 2025

Proposed changes

  • Added error message on search failing to completely load if landing on the search page (e.g. docs.nginx.com/search.html).
  • Added new partial called search-error.html for search error message.
    • Decoupled this from the search layout in case in the future, we might need to use it elsewhere if we change search providers. Also cleaner and consistent code in general like this.
  • Added new test to check for missing credentials.
  • Added new GH secret called COVEO_CREDENTIALS_BASE_URL.
  • Refactored coveo testing code to move certain variables to be shared.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Nov 5, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner November 5, 2025 22:07
@lamATnginx lamATnginx added the enhancement New feature or request label Nov 5, 2025
@lamATnginx lamATnginx marked this pull request as draft November 5, 2025 22:07
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/438/

@lamATnginx lamATnginx marked this pull request as ready for review November 5, 2025 22:51
@lamATnginx lamATnginx changed the title Handle failed to fetch Coveo credentials from endpoint Handle failure to fetch Coveo credentials from endpoint Nov 5, 2025
@lamATnginx lamATnginx changed the title Handle failure to fetch Coveo credentials from endpoint Handle failure to fetch Coveo credentials from endpoint in UI Nov 5, 2025
@github-actions

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Playwright differences were detected.

View the Playwright report

@TasoOneAsia
Copy link
Member

Looks like the playwright test is timing out in CI, I ran it again with the same result.

@lamATnginx lamATnginx changed the title Handle failure to fetch Coveo credentials from endpoint in UI Handle failure to fetch Coveo credentials in UI Nov 7, 2025
@lamATnginx
Copy link
Collaborator Author

lamATnginx commented Nov 7, 2025

Hold off on merging. We need to add some tickets around refactoring sidebar test + speed of downloading playwright browsers + dep.

Edit: Done

@TasoOneAsia TasoOneAsia marked this pull request as draft November 7, 2025 16:06
@TasoOneAsia
Copy link
Member

Marking as draft per the last message.

@lamATnginx lamATnginx marked this pull request as ready for review November 7, 2025 16:34
@lamATnginx lamATnginx merged commit 86b8633 into main Nov 7, 2025
7 checks passed
@lamATnginx lamATnginx deleted the add/coveo-error-msg branch November 7, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants