fix: onHide emit only if ref is not destroyed

talfaran · talfaran · commit 300c4f0c0553 · 2025-05-25T18:08:39.000+03:00
diff --git a/projects/ngneat/helipopper/src/lib/tippy.directive.ts b/projects/ngneat/helipopper/src/lib/tippy.directive.ts
@@ -587,13 +587,13 @@ export class TippyDirective implements OnChanges, AfterViewInit, OnInit {
     // "Unexpected emit for destroyed `OutputRef`".
     if (!this.destroyed) {
       this.isVisible.set(isVisible);
+      this.onHide.emit();
     }
     this.visibleInternal.next(isVisible);
     if (this.visible.observed) {
       this.ngZone.run(() => this.visible.next(isVisible));
     }
     this.globalConfig.onHidden?.(instance);
-    this.onHide.emit();
   }
 
   private isOverflowing$() {

Original file line number	Diff line number	Diff line change
`@@ -587,13 +587,13 @@ export class TippyDirective implements OnChanges, AfterViewInit, OnInit {`
`587`	`587`	// "Unexpected emit for destroyed `OutputRef`".
`588`	`588`	`if (!this.destroyed) {`
`589`	`589`	`this.isVisible.set(isVisible);`
	`590`	`+ this.onHide.emit();`
`590`	`591`	`}`
`591`	`592`	`this.visibleInternal.next(isVisible);`
`592`	`593`	`if (this.visible.observed) {`
`593`	`594`	`this.ngZone.run(() => this.visible.next(isVisible));`
`594`	`595`	`}`
`595`	`596`	`this.globalConfig.onHidden?.(instance);`
`596`		`- this.onHide.emit();`
`597`	`597`	`}`
`598`	`598`
`599`	`599`	`private isOverflowing$() {`