fix: markAllDirty(FormGroup) not marking children

shajz · shajz · commit 5dcab341b8d2 · 2022-01-03T23:46:29.000+01:00
FormControl doesn't have a markAllAsDirty method Closes #135
diff --git a/libs/reactive-forms/src/lib/core.ts b/libs/reactive-forms/src/lib/core.ts
@@ -134,5 +134,5 @@ export function controlErrorChanges$(
 export function markAllDirty(control: AbstractControl): void {
   control.markAsDirty({ onlySelf: true });
 
-  (control as any)._forEachChild((control: any) => control.markAllAsDirty?.());
+  (control as any)._forEachChild((control: any) => control.markAllAsDirty?.() || control.markAsDirty({ onlySelf: true }));
 }

Original file line number	Diff line number	Diff line change
`@@ -134,5 +134,5 @@ export function controlErrorChanges$(`
`134`	`134`	`export function markAllDirty(control: AbstractControl): void {`
`135`	`135`	`control.markAsDirty({ onlySelf: true });`
`136`	`136`
`137`		`- (control as any)._forEachChild((control: any) => control.markAllAsDirty?.());`
	`137`	`+ (control as any)._forEachChild((control: any) => control.markAllAsDirty?.() \|\| control.markAsDirty({ onlySelf: true }));`
`138`	`138`	`}`