Merge pull request #136 from shajz/fix.markAllAsDirty

Author: NetanelBasal

libs/reactive-forms/src/lib/core.ts

@@ -134,5 +134,5 @@ export function controlErrorChanges$(
 export function markAllDirty(control: AbstractControl): void {
   control.markAsDirty({ onlySelf: true });
 
-  (control as any)._forEachChild((control: any) => control.markAllAsDirty?.());
+  (control as any)._forEachChild((control: any) => control.markAllAsDirty?.() || control.markAsDirty({ onlySelf: true }));
 }

libs/reactive-forms/src/lib/form-group.spec.ts

@@ -196,6 +196,20 @@ describe('FormGroup Functionality', () => {
     expect(spy).toHaveBeenCalledWith(false);
   });
 
+  function areAllAllChildrenDirty(control: AbstractControl) {
+    expect(control.dirty).toBe(true);
+    (control as any)._forEachChild((control: AbstractControl) => areAllAllChildrenDirty(control));
+  }
+
+  it('should markAllAsDirty', () => {
+    const control = createGroup();
+
+    jest.spyOn(control, 'markAsDirty');
+    control.markAllAsDirty();
+    expect(control.markAsDirty).toHaveBeenCalled();
+    areAllAllChildrenDirty(control);
+  });
+
   it('should reset', () => {
     const control = createGroup();
     jest.spyOn(control, 'reset');