feat: only emit value when control is valid #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NetanelBasal
reviewed
Oct 4, 2023
| @@ -1,17 +1,14 @@ | |||
| name: '@ngneat/reactive-forms' | |||
| name: 'lothern/reactive-forms' | |||
There was a problem hiding this comment.
Sorry, those changes weren't supposed to make it into the master branch. I've corrected it.
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
The entire code uses lothern?
There was a problem hiding this comment.
Sorry, those changes weren't supposed to make it into the master branch. I've corrected it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#182
Issue Number: 182
What is the new behavior?
New property called validValue$ that only emits when a value is valid.
Does this PR introduce a breaking change?
Other information