Allow Generic for featureName
for StoreModule.forFeature()
#3084
ZackDeRose
started this conversation in
Ideas
Replies: 1 comment
-
Will you add some sample code of what you see the changes enabling? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Describe any alternatives/workarounds you're currently using
Had a task to recently lock down the accepted ngrx feature names to a specific set of names.
To accomplish, we created a typed shim for the
StoreModule
that overrode theforFeature()
method to give a proper type to the featureName param.Adding another generic to this method (that defaults to any string) should solve this, without causing breaking changes.
Other information:
Discussed this with @brandonroberts, who asked me to open this issue!
If accepted, I would be willing to submit a PR for this feature
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
Beta Was this translation helpful? Give feedback.
All reactions