NgRx SignalStore - Warning displayed for private members

[andy-bond]

Which @ngrx/* package(s) are the source of the bug?

signals

Minimal reproduction of the bug/regression with instructions

https://stackblitz.com/edit/ngrx-signals-override-private-variables?file=src%2Fmain.ts

(check the console)

Expected behavior

Ideally, this warning would not surface if the "overridden" member is coming from a signal store feature - as it means we would have to name things in special ways to ensure that we don't see collisions when consuming reusable signal store features.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)

NgRx: 19 or 20
Angular: 19 or 20
Node: 20
OS: Mac

Other information

I gave a simple example in the StackBlitz, but in my real use case, I am pretty consistently using something like:

withProps(() => {
  const _dependency1 = inject(MyDependency1);

  return {
    _dependency1
  }
})

If I have multiple SignalStoreFeatures that use that same dependency, then I run into issues with this warning appearing saying that I'm overriding a member.

I would be willing to submit a PR to fix this issue

• Yes
• No

[rainerhahnekamp]

@andy-bond, even for reusable features, you want to know if there - let me use another word - is a collision in terms of properties, methods, etc.

It is true, that it makes it hard to reach a 100% non-overridable feature. Others have already raised this concern as well: #4825

If okay with you, I'd like to move this into the discussion area.

[andy-bond]

Just to confirm, I believe this warning is surfaced here using Reflect: https://github.com/ngrx/platform/blob/main/modules/signals/src/signal-store-assertions.ts#L18

Is an underscore prefixed member actually being overwritten by later store features (therefore the warning is correct) or is it actually private and the warning is surfacing because the Reflect doesn't care if it is prefixed with an underscore or not?

[jdegand]

Using Reflect.ownKeys may compromise type safety. Could that be relevant here?