Merging main issues

[jdegand]

This has happened multiple times. I merge main and I have to clean up after the merge because the added code has formatting issues. Is the added code not being verified with husky? Should I use no-verify when I merge main? Is this documented in the contributing guide?

[jdegand]

Husky hook will not run if pnpm install is not used. So any documentation changes can make it through without being formatted. I checked the workflow files and prettier is not being run. So the formatting issues do make it to main.

Here's an updated workflow to run prettier on changed files:

name: main

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

permissions:
  actions: read
  contents: read

concurrency:
  group: ${{ github.workflow }}-${{ github.event.number || github.sha }}
  cancel-in-progress: true

jobs:
  format-check:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
        with:
          fetch-depth: 0

      - run: npm install --global [email protected]
      - run: corepack enable

      - uses: actions/setup-node@v4
        with:
          node-version-file: .node-version
          cache: 'pnpm'
          cache-dependency-path: '**/pnpm-lock.yaml'

      - run: pnpm install --frozen-lockfile --prefer-offline

      - uses: nrwl/nx-set-shas@v4

      - name: Check formatting on changed files
        run: pnpm exec nx format:check

[jdegand]

Update:

Husky hook is fine.

Ran prettier on main and only one file had an issue (modules/eslint-plugin/scripts/generate-config.ts).

It looks like the issue could be related to the GitHub codespace environment. The extensions are installed automatically and prettier is a dev dependency so I don't get why the precommit could fail. Maybe, a high CPU usage issue again? Anytime you see a high CPU warning in a GitHub codespace something goes wrong. Running all tests at once always causes high CPU usage.

[jdegand]

GitHub codespace high CPU usage causes the precommit hook to fail or not run correctly.