Missing build instructions, linking problems

[ArtemKhvostov]

Hi!
I am trying to build this bridge for my dscope.
Didnt find build instructions, i did:
mkdir build && cd build && cmake .. && make
make failed on link:
[ 17%] Built target xptools [ 47%] Built target log [ 64%] Built target scpi-server-tools [ 70%] Linking CXX executable scopehal-sigrok-bridge /usr/bin/ld: /usr/local/lib/libsigrok4DSL.so: undefined reference to 'DS_RES_PATH' collect2: error: ld returned 1 exit status make[2]: *** [CMakeFiles/scopehal-sigrok-bridge.dir/build.make:164: scopehal-sigrok-bridge] Error 1 make[1]: *** [CMakeFiles/Makefile2:138: CMakeFiles/scopehal-sigrok-bridge.dir/all] Error 2 make: *** [Makefile:91: all] Error 2
What did I do wrong? Google search gives nothing about the missing 'DS_RES_PATH' and so did the search through all repositories i have checked out. So I don't even know what exactly uses this parameter and how...

OS is Ubuntu 20.04

[ArtemKhvostov]

libsigrok4DSL version 1.0.2

[ArtemKhvostov]

aha, seems that DSLab integrated libsigrok4DSL into DSView entirely and removed building and installation of it as separate module, and i had some oldish one... but still something is broken

It should probably copied/submoduled into this repo therefore

[ArtemKhvostov]

So, checking out commit 5a9481fd0697d66ce5ce0e46a8d233125e6cb5ac of DSView and building and installing the libsigrok4DSL helped.
this commit is the last one which still has build stuff for this as a separate library.
This is still just a workaround and should be addressed properly, as i said before probably by submoduling DSView.
And a build instructions are necessary

[ArtemKhvostov]

found submodule for dsview in the parent repo, but building and installing it leads to compile failure for the bridge:

/<repo_addr>/ngscope/scopehal-sigrok-bridge/src/srbinding.cpp:66:6: error: ‘SR_CONF_PROBE_VDIV’ was not declared in this scope; did you mean ‘SR_CONF_NUM_VDIV’?
   66 |     {SR_CONF_PROBE_VDIV, "vdivs"},
      |      ^~~~~~~~~~~~~~~~~~
      |      SR_CONF_NUM_VDIV
/<repo_addr>/ngscope/scopehal-sigrok-bridge/src/srbinding.cpp:68:1: error: no matching function for call to ‘std::map<int, std::__cxx11::basic_string<char> >::map(<brace-enclosed initializer list>)’
   68 | };

[amigomcu]

hi all,
maybe git lib to the commit id.

cd log
git reset --hard 1e43c71
cd scpi-server-tools
git reset --hard 8c2bd49
cd xptools
git reset --hard 1e43c71

2. edit ld.so.conf ,add the lib path
   steven@steven-VirtualBox:/scopehal-sigrok-bridge/build$ sudo vim /etc/ld.so.conf
   steven@steven-VirtualBox:/scopehal-sigrok-bridge/build$ sudo /sbin/ldconfig -v

steven@steven-VirtualBox:/scopehal-sigrok-bridge/build$ ./scopehal-sigrok-bridge --help
libsigrok4DSL ver: '0.2.0'
ERROR: Didn't find driver.
steven@steven-VirtualBox:/scopehal-sigrok-bridge/build$ ./scopehal-sigrok-bridge
Usage: ./scopehal-sigrok-bridge

[amigomcu]

found submodule for dsview in the parent repo, but building and installing it leads to compile failure for the bridge:

/<repo_addr>/ngscope/scopehal-sigrok-bridge/src/srbinding.cpp:66:6: error: ‘SR_CONF_PROBE_VDIV’ was not declared in this scope; did you mean ‘SR_CONF_NUM_VDIV’?
   66 |     {SR_CONF_PROBE_VDIV, "vdivs"},
      |      ^~~~~~~~~~~~~~~~~~
      |      SR_CONF_NUM_VDIV
/<repo_addr>/ngscope/scopehal-sigrok-bridge/src/srbinding.cpp:68:1: error: no matching function for call to ‘std::map<int, std::__cxx11::basic_string<char> >::map(<brace-enclosed initializer list>)’
   68 | };

hi all,
maybe git lib to the commit id.

cd log
git reset --hard 1e43c71
cd scpi-server-tools
git reset --hard 8c2bd49
cd xptools
git reset --hard 1e43c71

2. edit ld.so.conf ,add the lib path
   steven@steven-VirtualBox:/scopehal-sigrok-bridge/build$ sudo vim /etc/ld.so.conf
   steven@steven-VirtualBox:/scopehal-sigrok-bridge/build$ sudo /sbin/ldconfig -v

steven@steven-VirtualBox:/scopehal-sigrok-bridge/build$ ./scopehal-sigrok-bridge --help
libsigrok4DSL ver: '0.2.0'
ERROR: Didn't find driver.
steven@steven-VirtualBox:/scopehal-sigrok-bridge/build$ ./scopehal-sigrok-bridge
Usage: ./scopehal-sigrok-bridge